feat(session-replay-browser): in memory events storage #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewgordon-amplitude
changed the title
lewgordon-amplitude
force-pushed
the
AMP-112171-in-memory-provider
branch
from
2382649 to
1215806
Compare
…more generic interface
fix(session-replay-browser): options
…dexedDB is not present fix(session-replay-browser): unifying how the memory splitting works
test(session-replay-browser): add coverage for events-idb-store test(session-replay-browser): base event store test(session-replay-browser): in memory store tests test(session-replay-browser): config coverage test(session-replay-browser): fix tests from refactor
lewgordon-amplitude
force-pushed
the
AMP-112171-in-memory-provider
branch
from
1215806 to
5b15d87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Do not merge, still testing with the tasks appCurrently, we store events using indexedDB (IDB). However, it's not possible in all cases where we want to capture replays that IDB is present. This PR adds an in-memory version of the event store that can either be the default store or will be the fallback if IDB is not present. The storage API is not quite stable yet and the implementation to make both stores unified needs a bit of work. This is small holdover to help in certain situations and to prevent a very large initial PR.
Sorry for the long PR! This was an attempt at the minimal amount of changes with a few quality of life things thrown in.
Checklist