Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(session-replay-browser): support custom urls for remote config and track endpoints. #931

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

lewgordon-amplitude
Copy link

Summary

This allows for custom urls for the remote config and track endpoints to help with testing against mocked or local versions of these services. There is an old config that was changed, but it seems like that was not used at all.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: Yes, but the old config was not used.

@lewgordon-amplitude lewgordon-amplitude requested review from jxiwang and a team December 9, 2024 21:54
Copy link

@jxiwang jxiwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lewgordon-amplitude lewgordon-amplitude merged commit af6aa43 into v1.x Dec 10, 2024
4 checks passed
@lewgordon-amplitude lewgordon-amplitude deleted the lew/support-custom-urls branch December 10, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants