fix: Do not track empty assignment events

amplitude · Sep 19, 2023 · a16d809 · a16d809
1 parent 4a8107c
commit a16d809
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/main/kotlin/assignment/AssignmentFilter.kt b/src/main/kotlin/assignment/AssignmentFilter.kt
@@ -12,6 +12,9 @@ internal class InMemoryAssignmentFilter(size: Int, ttlMillis: Long = DAY_MILLIS)
     private val cache = Cache<String, Unit>(size, ttlMillis)
 
     override fun shouldTrack(assignment: Assignment): Boolean {
+        if (assignment.results.isEmpty()) {
+            return false
+        }
         val canonicalAssignment = assignment.canonicalize()
         val track = cache[canonicalAssignment] == null
         if (track) {

diff --git a/src/test/kotlin/assignment/AssignmentFilterTest.kt b/src/test/kotlin/assignment/AssignmentFilterTest.kt
@@ -89,7 +89,7 @@ class AssignmentFilterTest {
             ExperimentUser(userId = "user"),
             mapOf()
         )
-        Assert.assertTrue(filter.shouldTrack(assignment1))
+        Assert.assertFalse(filter.shouldTrack(assignment1))
         val assignment2 = Assignment(
             ExperimentUser(userId = "user"),
             mapOf()
@@ -99,7 +99,7 @@ class AssignmentFilterTest {
             ExperimentUser(userId = "different user"),
             mapOf()
         )
-        Assert.assertTrue(filter.shouldTrack(assignment3))
+        Assert.assertFalse(filter.shouldTrack(assignment3))
     }
 
     @Test