Skip to content

Commit

Permalink
update LocalEvaluationClient.kt to use FLAG_TYPE constants
Browse files Browse the repository at this point in the history
  • Loading branch information
Tim Yiu authored and Tim Yiu committed Aug 28, 2023
1 parent befd64c commit d9af032
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions src/main/kotlin/LocalEvaluationClient.kt
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@ import com.amplitude.experiment.assignment.AmplitudeAssignmentService
import com.amplitude.experiment.assignment.Assignment
import com.amplitude.experiment.assignment.AssignmentService
import com.amplitude.experiment.assignment.InMemoryAssignmentFilter
import com.amplitude.experiment.evaluation.EvaluationEngine
import com.amplitude.experiment.evaluation.EvaluationEngineImpl
import com.amplitude.experiment.evaluation.FlagResult
import com.amplitude.experiment.evaluation.*
import com.amplitude.experiment.evaluation.serialization.SerialVariant
import com.amplitude.experiment.flag.FlagConfigApiImpl
import com.amplitude.experiment.flag.FlagConfigService
Expand Down Expand Up @@ -62,7 +60,7 @@ class LocalEvaluationClient internal constructor(
val isVariant = !entry.value.isDefaultVariant
val isIncluded = (flagKeys.isEmpty() || flagKeys.contains(entry.key))
val isDeployed = entry.value.deployed
if (isIncluded || entry.value.type == "mutual-exclusion-group" || entry.value.type == "holdout-group") {
if (isIncluded || entry.value.type == FLAG_TYPE_MUTUAL_EXCLUSION_GROUP || entry.value.type == FLAG_TYPE_HOLDOUT_GROUP) {
assignmentResults[entry.key] = entry.value
}
isVariant && isIncluded && isDeployed
Expand Down

0 comments on commit d9af032

Please sign in to comment.