fix: don't track empty assignment events (#31)

amplitude · Sep 19, 2023 · 53f3506 · 53f3506
1 parent e0a4e52
commit 53f3506
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/packages/node/src/assignment/assignment-filter.ts b/packages/node/src/assignment/assignment-filter.ts
@@ -11,6 +11,10 @@ export class InMemoryAssignmentFilter implements AssignmentFilter {
   }
 
   public shouldTrack(assignment: Assignment): boolean {
+    if (Object.keys(assignment.results).length === 0) {
+      // Don't track empty assignments.
+      return false;
+    }
     const canonicalAssignment = assignment.canonicalize();
     const track = this.cache.get(canonicalAssignment) == undefined;
     if (track) {

diff --git a/packages/node/test/local/assignment/assignment-filter.test.ts b/packages/node/test/local/assignment/assignment-filter.test.ts
@@ -106,9 +106,9 @@ test('filter - empty result', async () => {
   const assignment1 = new Assignment(user1, {});
   const assignment2 = new Assignment(user1, {});
   const assignment3 = new Assignment(user2, {});
-  expect(filter.shouldTrack(assignment1)).toEqual(true);
+  expect(filter.shouldTrack(assignment1)).toEqual(false);
   expect(filter.shouldTrack(assignment2)).toEqual(false);
-  expect(filter.shouldTrack(assignment3)).toEqual(true);
+  expect(filter.shouldTrack(assignment3)).toEqual(false);
 });
 
 test('filter - duplicate assignments with different result ordering', async () => {