Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.2 Compatibility #532

Closed
swissspidy opened this issue Aug 23, 2022 · 0 comments · Fixed by #533
Closed

PHP 8.2 Compatibility #532

swissspidy opened this issue Aug 23, 2022 · 0 comments · Fixed by #533
Milestone
0.11.3

Comments

@swissspidy
Copy link
Contributor

PHP 8.2 is expected to be released at the end of November 2022.

Figured it can't hurt to track PHP 8.2 compatibility in a dedicated ticket.

At first glance it looks like the dynamic properties deprecation creates some warnings.

Creation of dynamic property AmpProject\Dom\Document::$head is deprecated in /path/to/vendor/ampproject/amp-toolbox/src/Dom/Document/Filter/DeduplicateTag.php on line 65

Creation of dynamic property AmpProject\Dom\Document::$body is deprecated in /path/to/vendor/ampproject/amp-toolbox/src/Dom/Document/Filter/DeduplicateTag.php on line 65

Creation of dynamic property AmpProject\Dom\Document::$html is deprecated in /path/to/vendor/ampproject/amp-toolbox/src/Dom/Document.php on line 699

Creation of dynamic property AmpProject\Dom\Document::$xpath is deprecated in /path/to/vendor/ampproject/amp-toolbox/src/Dom/Document.php on line 687
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.3
Development

Successfully merging a pull request may close this issue.

PHP 8.2 Improvements
2 participants
@westonruter @swissspidy