Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests against PHP 8.2 #12161

Merged
merged 6 commits into from
Sep 14, 2022
Merged

Run tests against PHP 8.2 #12161

merged 6 commits into from
Sep 14, 2022

Conversation

swissspidy
Copy link
Collaborator

@swissspidy swissspidy commented Aug 23, 2022

Context

PHP 8.2 is expected to be released at the end of November 2022.

Core is now also running tests against PHP 8.2, see https://core.trac.wordpress.org/changeset/53922

Summary

Enables running the PHP integration and unit tests on PHP 8.2.

Relevant Technical Choices

To-do

User-facing changes

N/A

Testing Instructions

  • This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

Reviews

Does this PR have a security-related impact?

No

Does this PR change what data or activity we track or use?

No

Does this PR have a legal-related impact?

No

Checklist

  • This PR addresses an existing issue and I have linked this PR to it in ZenHub
  • I have tested this code to the best of my abilities
  • I have verified accessibility to the best of my abilities (docs)
  • I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
  • This code is covered by automated tests (unit, integration, and/or e2e) to verify it works as intended (docs)
  • I have added documentation where necessary
  • I have added a matching Type: XYZ label to the PR

See #12163

@swissspidy swissspidy added PHP Pull requests that update PHP code Group: WordPress Changes related to WordPress or Gutenberg integration Pod: WP labels Aug 23, 2022
@spacedmonkey
Copy link
Contributor

Seems to be a number of deprecated warnings.

PHP Deprecated:  Creation of dynamic property Google\Web_Stories_Dependencies\AmpProject\Dom\Document::$head is deprecated in /home/runner/work/web-stories-wp/web-stories-wp/third-party/vendor/ampproject/amp-toolbox/src/Dom/Document/Filter/DeduplicateTag.php on line 65
PHP Deprecated:  Creation of dynamic property Google\Web_Stories_Dependencies\AmpProject\Dom\Document::$body is deprecated in /home/runner/work/web-stories-wp/web-stories-wp/third-party/vendor/ampproject/amp-toolbox/src/Dom/Document/Filter/DeduplicateTag.php on line 65
PHP Deprecated:  Creation of dynamic property Google\Web_Stories_Dependencies\AmpProject\Dom\Document::$html is deprecated in /home/runner/work/web-stories-wp/web-stories-wp/third-party/vendor/ampproject/amp-toolbox/src/Dom/Document.php on line 699
PHP Deprecated:  Creation of dynamic property Google\Web_Stories_Dependencies\AmpProject\Dom\Document::$xpath is deprecated in /home/runner/work/web-stories-wp/web-stories-wp/third-party/vendor/ampproject/amp-toolbox/src/Dom/Document.php on line 687

@swissspidy swissspidy marked this pull request as ready for review September 12, 2022 19:25
@swissspidy
Copy link
Collaborator Author

Tests are passing now, just with a ton of warnings from the aforementioned dependencies.

@swissspidy swissspidy merged commit 2cf5f80 into main Sep 14, 2022
@swissspidy swissspidy deleted the try/php-8.2-tests branch September 14, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Group: WordPress Changes related to WordPress or Gutenberg integration PHP Pull requests that update PHP code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants