Add TemporaryFileCachedRemoteGetRequest to cache cURL request #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@schlessera Need your suggestions to add the test cases for |
schlessera
requested changes
Nov 19, 2021
Filesystem-based manipulations can be tested in an easy way with https://github.com/bovigo/vfsStream. |
DateTimeImmutable does not give micro seconds in PHP < 7.1. @see: https://www.php.net/manual/en/migration71.incompatible.php#migration71.incompatible.datetime-microseconds
|
@schlessera Updated the PR with test cases. Please take a look. |
schlessera
requested changes
Nov 23, 2021
tests/RemoteRequest/TemporaryFileCachedRemoteGetRequestTest.php
Outdated
Show resolved
Hide resolved
tests/RemoteRequest/TemporaryFileCachedRemoteGetRequestTest.php
Outdated
Show resolved
Hide resolved
tests/RemoteRequest/TemporaryFileCachedRemoteGetRequestTest.php
Outdated
Show resolved
Hide resolved
tests/RemoteRequest/TemporaryFileCachedRemoteGetRequestTest.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Alain Schlesser <alain.schlesser@gmail.com>
schlessera
requested changes
Dec 1, 2021
Co-authored-by: Alain Schlesser <alain.schlesser@gmail.com>
schlessera
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added a temporary file cache system to cache the remote request response. This will improve the performance issue described in issue #292.