Cache only valid responses #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dritter
force-pushed
the
cache-only-valid-responses
branch
from
5ec7828
to
f5c6b83
Compare
m1rm
approved these changes
Aug 15, 2022
|
@schlessera Any chance to get this merged? This is quite urgent for us, because all our amp pages are invalid without this fix (see #530 ). |
|
cc @westonruter |
westonruter
approved these changes
Sep 1, 2022
| @@ -132,7 +132,7 @@ static function ($curl, $header) use (&$headers) { | |||
| $curlErrno = curl_errno($curlHandle); | |||
| curl_close($curlHandle); | |||
|
|
|||
| if ($body === false) { | |||
| if ($body === false || $status < 200 || $status >= 300) { | |||
There was a problem hiding this comment.
This should work as expected, but note that I believe $status could be 0. In this case, $body should also be false.
There was a problem hiding this comment.
Hey! I am not sure, if I understand you correctly. Is there anything to do left?
If $status can be 0, it should IMHO be treated as error. And this code does that (smaller than 200).
There was a problem hiding this comment.
Yeah, I'm saying the same thing. In the error case, $status should be 0 and it will work as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Recently we discovered that some requests to fetch the metadata failed, but were cached regardless of the status code. This PR adds a guard, that only valid responses are cached.
This fixes #530