Merge pull request #1444 from Automattic/update/1361-unsortable-detai…

…ls-column

Error listing view - make details column unsortable

includes/validation/class-amp-validation-error-taxonomy.php

@@ -68,13 +68,6 @@ class AMP_Validation_Error_Taxonomy {
 	 */
 	const VALIDATION_ERROR_TYPE_QUERY_VAR = 'amp_validation_error_type';
 
-	/**
-	 * Query var used for ordering list by node name.
-	 *
-	 * @var string
-	 */
-	const VALIDATION_DETAILS_NODE_NAME_QUERY_VAR = 'amp_validation_node_name';
-
 	/**
 	 * Query var used for ordering list by error code.
 	 *
@@ -653,7 +646,6 @@ public static function add_admin_hooks() {
 		add_filter( 'manage_edit-' . self::TAXONOMY_SLUG . '_sortable_columns', function( $sortable_columns ) {
 			$sortable_columns['created_date_gmt'] = 'term_id';
 			$sortable_columns['error_type']       = AMP_Validation_Error_Taxonomy::VALIDATION_ERROR_TYPE_QUERY_VAR;
-			$sortable_columns['details']          = AMP_Validation_Error_Taxonomy::VALIDATION_DETAILS_NODE_NAME_QUERY_VAR;
 			$sortable_columns['error']            = AMP_Validation_Error_Taxonomy::VALIDATION_DETAILS_ERROR_CODE_QUERY_VAR;
 			return $sortable_columns;
 		} );
@@ -820,7 +812,6 @@ public static function add_order_clauses_from_description_json() {
 
 		$sortable_column_vars = array(
 			self::VALIDATION_ERROR_TYPE_QUERY_VAR,
-			self::VALIDATION_DETAILS_NODE_NAME_QUERY_VAR,
 			self::VALIDATION_DETAILS_ERROR_CODE_QUERY_VAR,
 		);
 
@@ -846,13 +837,6 @@ public static function add_order_clauses_from_description_json() {
 					);
 					break;
 
-				case AMP_Validation_Error_Taxonomy::VALIDATION_DETAILS_NODE_NAME_QUERY_VAR:
-					$clauses['orderby'] = $wpdb->prepare(
-						'ORDER BY SUBSTR(tt.description, LOCATE(%s, tt.description))',
-						'"node_name":"'
-					);
-					break;
-
 				case AMP_Validation_Error_Taxonomy::VALIDATION_DETAILS_ERROR_CODE_QUERY_VAR:
 					$clauses['orderby'] = $wpdb->prepare(
 						'ORDER BY SUBSTR(tt.description, LOCATE(%s, tt.description))',