Remove grunt-contrib-jshint from deploy step

Gruntfile.js

@@ -9,17 +9,6 @@ module.exports = function( grunt ) {
 
 		pkg: grunt.file.readJSON( 'package.json' ),
 
-		// JavaScript linting with JSHint.
-		jshint: {
-			options: {
-				jshintrc: '.jshintrc'
-			},
-			all: [
-				'Gruntfile.js',
-				'assets/**/*.js'
-			]
-		},
-
 		// Clean up the build.
 		clean: {
 			build: {
@@ -72,7 +61,6 @@ module.exports = function( grunt ) {
 	// Load tasks.
 	grunt.loadNpmTasks( 'grunt-contrib-clean' );
 	grunt.loadNpmTasks( 'grunt-contrib-copy' );
-	grunt.loadNpmTasks( 'grunt-contrib-jshint' );
 	grunt.loadNpmTasks( 'grunt-shell' );
 	grunt.loadNpmTasks( 'grunt-wp-deploy' );
 
@@ -180,7 +168,6 @@ module.exports = function( grunt ) {
 	] );
 
 	grunt.registerTask( 'deploy', [
-		'jshint',
 		'shell:phpunit',
 		'shell:verify_matching_versions',
 		'wp_deploy'

contributing.md

@@ -139,17 +139,18 @@ When you push a commit to your PR, Travis CI will run the PHPUnit tests and snif
 Contributors who want to make a new release, follow these steps:
 
 0. Do `git submodule update --init --recursive && npm install && composer selfupdate && composer install && wp cli update`.
-1. Do `npm run build` and install the `amp.zip` onto a normal WordPress install running a stable release build; do smoke test to ensure it works.
-2. Bump plugin versions in `amp.php` (×2: the metadata block in the header and also the `AMP__VERSION` constant).
-3. Add changelog entry to readme.
-4. Draft blog post about the new release.
-5. [Draft new release](https://github.com/ampproject/amp-wp/releases/new) on GitHub targeting the release branch, with the new plugin version as the tag and release title. Attaching the `amp.zip` build to the release. Include link to changelog in release tag.
-6. Run `npm run deploy` to to commit the plugin to WordPress.org.
-7. Confirm the release is available on WordPress.org; try installing it on a WordPress install and confirm it works.
-8. Publish GitHub release.
-9. Create built release tag: `git fetch --tags && git checkout $(git tag | tail -n1) && ./bin/tag-built.sh` (then add link from release)
-10. Create a new branch off of the release branch, merge `develop` into it and resolve conflicts (e.g. with version and changelog), and then open pull request to merge changes into `develop`.
-11. Merge release tag into `master`.
-12. Publish release blog post, including link to GitHub release.
-13. Close the GitHub milestone and project.
-14. Make announcements.
+1. Bump plugin versions in `amp.php` (×2: the metadata block in the header and also the `AMP__VERSION` constant). Verify via `npx grunt shell:verify_matching_versions`.
+2. Add changelog entry to readme.
+3. Do `npm run build` and install the `amp.zip` onto a normal WordPress install running a stable release build; do smoke test to ensure it works.
+4. Do sanity check by comparing the `build` directory with the previously-deployed plugin at http://plugins.svn.wordpress.org/amp/trunk
+5. Draft blog post about the new release.
+6. [Draft new release](https://github.com/ampproject/amp-wp/releases/new) on GitHub targeting the release branch, with the new plugin version as the tag and release title. Attaching the `amp.zip` build to the release. Include link to changelog in release tag.
+7. Run `npm run deploy` to to commit the plugin to WordPress.org.
+8. Confirm the release is available on WordPress.org; try installing it on a WordPress install and confirm it works.
+9. Publish GitHub release.
+10. Create built release tag: `git fetch --tags && git checkout $(git tag | tail -n1) && ./bin/tag-built.sh` (then add link from release)
+11. Create a new branch off of the release branch, merge `develop` into it and resolve conflicts (e.g. with version and changelog), and then open pull request to merge changes into `develop`.
+12. Merge release tag into `master`.
+13. Publish release blog post, including link to GitHub release.
+14. Close the GitHub milestone and project.
+15. Make announcements.

package.json

@@ -23,7 +23,6 @@
   "grunt": "^1.0.2",
   "grunt-contrib-clean": "^1.1.0",
   "grunt-contrib-copy": "^1.0.0",
-  "grunt-contrib-jshint": "^1.1.0",
   "grunt-shell": "^2.1.0",
   "grunt-wp-deploy": "^1.2.1",
   "timeago.js": "3.0.2",