-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blocks > Do not allow more than one block inside the AMP Grid layer when the 'fill' template is selected #1526
Comments
This one will need some design feedback in terms of the messaging. We'll need to look into what kind of messaging option Gutenberg has now and then verify if we should change it. |
Note for dev: Development can be started independent of UX/Design work an consulted later to see if the existing messaging options are suitable as they are. Note that this ticket is blocked by #1530 since after creating different blocks then AMP Layer |
Had a chat with @alcurrie today and wanted to share a sketch that walks through the discussion. Currently we want to make sure that we're actively stopping users from doing the following:
|
@jwold Thanks for sharing the sketches and detailed thoughts for different cases. Some thoughts: For example one option could be that in case of Fill Layer we would always display a static message saying something like: "Note that Fill Layer can have only one inner element. Any additional blocks will be removed automatically." This would mean that we wouldn't have to worry about different cases for pressing return/enter of typing in Do you think this might still be confusing? Thoughts? cc @alcurrie |
Fixed within #1594. |
The user is not blocked from adding a new block to an image fill layer using the 'insert block'. See screencast: https://cl.ly/24e2f604ef79 |
@alcurrie The screencast shows that the paragraph is created after the Image Fill Layer (inside Page block) but not inside the image Fill Layer. The AC1 here is for not being able to add more than one block into Fill Layer which seems to be true -- it's not possible to add another block inside the Image Fill Layer. The bug that you found seems to be a separate general issue, not a Fill Layer related issue, and would probably need a new ticket. The issue title could be something like: It should not be possible to add any other blocks than Layer blocks and CTA blocks inside the Page block. |
Thanks for clarifying @miina -I'll move this back into QA and re-test, and check the 'other' issue and add a new ticket. |
I've confirmed the AC for adding an image fill layer are met, as follows: |
As a editor/author creating an AMP story I want to be prevented from adding more than one block to the AMP Grid Layer when using the 'fill template' so that I don't hide all the 'other' blocks by mistake.
Background on this change
This brings the functionality in alignment with the expected functionality on the FE and avoids user confusion when the template fill seems to ‘hide’ all other blocks except the first one. From a user perspective the AMP Grid Layer with Template ‘Fill’ hides all the other blocks except the first one. This can cause issues using the default paragraph block in a layer when background image fill is set. ie. see this example where the image block added first covers/hides the 'text' block. https://d.pr/i/gHSAxO
The text was updated successfully, but these errors were encountered: