-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blocks > Make AMP Stories block more granular by providing different blocks for different layout options #1530
Comments
Questions/Notes for design/interface discussion NB: this may need to be split out into separate issues. |
Our understanding is that this issue is for the UX to only create icons for each of the new blocks, This is not blocked by UX for dev to begin. |
Icons needed:
|
@jwold Assigning this to you as well since there are icons needed, the dev part should be ready (everything except for implementing the icons). |
Also need to create separate icons for fill image and fill video. |
Would love some feedback on this! :) @miina, @alcurrie, @cathibosco |
Todo for later: we may want to make these stand out a bit differently in the inserter. For instance (crazy idea) adding a blue background to all items in the inserter that are for AMP Stories. |
Going to remove UX feedback for now, but happy to jump back in if need be! |
@jwold Thanks for the icons and for the thoughts, separating AMP Story blocks would be great, especially until it's not possible to hide all the non-AMP Story blocks. It's possible to create a separate category for AMP Story blocks as well, so they would all appear separately grouped :) One note on the icons: would it be possible to get these as .svg files, too? Whom should I ask for that? Thank you! |
Download link: svg-icons.zip |
Note: we ran into an issue with the SVG importing. @cathibosco is helping with making the SVG updates, which we'll post back to this issue. |
Revised SVG icon package version2 |
Fixed within #1594. |
Confirmed AC 1 and 2: splitting out into separate layer blocks, renaming layer blocks and updating the icons: https://cl.ly/0702f12301c6 2 questions:
|
Thanks @miina - I'll retest and add a note for the Wiki. Re. messages for the 'next phase' do you mean that we should consider adding support for other videos sizes for the next phase, or are there other video related enhancements that we should be tracking? |
@alcurrie I'm thinking that probably generally in the next phase we could look over all the existing features and see if we could make things easier for the editor by displaying relevant messages for best practices and recommendations for AMP Stories. Such as display the recommended image size / ratio and the same for video, etc. Thoughts? |
That's a great idea @miina. Let's track that that for next phase I've made a note to follow up after WCUS. I'll update the notes for the WIKI as well However this issue is confirmed complete, with the confirmation of the Video Autoplay. : https://cl.ly/3b53097e0789 |
As AMP story creator, I'd like the AMP Stories block to be more granular so I can split the grid layer, for different layout options.
The text was updated successfully, but these errors were encountered: