-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blocks > Creating a new Page block should have a block template with a background image layer (populated with a default image) and a vertical grid layer #1531
Comments
This one is not blocking development, UX just needs to provide a default image and an icon. [Edit: Suggestion for icon can be found here] |
Are we suggesting a placeholder video for video fill layer as well? Wondering if the placeholders don't quite make sense. |
@jwold Just saw this now, as chatted as well then probably having a default image / video wouldn't be the most user-friendly option and perhaps just expanding the default media selector to fill in the whole layer would make more sense at this moment. That should be quite straightforward to implement as well and if we see that in practice it doesn't seem to be a good idea then we could think of an alternative. Thoughts? cc @alcurrie |
@miina agreed. I think we should just expand the area and see how that "feels" when we get it live. Then probably go forward with that for now. Thanks! |
Selecting a layer beneath another is still not possible. I’ve spent 2 focused sessions on this ticket today and not much to show for :/ the animations / blurring are all UX improvements, but not being able to choose an image to upload in the lower layer is something still at play. There is a core click listener which changes the is-selected element as soon as you start clicking (it's on mouse down, not even on mouse up).. and it's bringing the next sibling in the DOM into focus - without the is-selected class until you click again though. The click handler comes from React-DOM: I'd like to bounce this off with someone else as I can't seem to get past beyond this blocker. :/ |
In our walk through and workshop sessions: We were discussing this:
|
@miina |
Just merged it in, should be deployed soon. |
Closing as fixed in #1600. |
I've confirmed adding a new page opens with a default template will include the following elements:
As discussed above, original AC was updated per discussion here: (#1531 (comment)) we recommended not including a default image and instead expanding the default media selector to fill in the whole layer. |
As an author creating a new AMP story page, I want the default block template to have a background image layer and a vertical grid layer. The background layer should be populated with a default image
populated with a default imagefrom the default image to another background image of their choosing.Note: AC was updated to not require background image as based on
The text was updated successfully, but these errors were encountered: