Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable/Filter Block Manager #2180

Closed
swissspidy opened this issue Apr 24, 2019 · 5 comments
Closed

Disable/Filter Block Manager #2180

swissspidy opened this issue Apr 24, 2019 · 5 comments
Milestone

Comments

@swissspidy
Copy link
Collaborator

Recently, Gutenberg added a block manager that allows you to disable (unregister) certain blocks completely.

While that might make sense for things like the Verse block, we don't want people to be able to unregister the AMP story, ever.

Either by removing these blocks from the block manager if possible, or alternatively by completely hiding the block manager.

@swissspidy
Copy link
Collaborator Author

swissspidy commented Apr 30, 2019

Opened an upstream issue here: WordPress/gutenberg#15265

@swissspidy swissspidy changed the title [AMP Stories] Disable/Filter Block Manager Disable/Filter Block Manager Apr 30, 2019
@swissspidy
Copy link
Collaborator Author

As decided in the current meeting, we should just disable/hide the block manager as a whole. We already provide a trimmed down list of AMP-compatible blocks, so there's not much value in further disabling them.

@swissspidy
Copy link
Collaborator Author

Testing instructions

  1. Click on the three dots in the top right corner
  2. Verify that in the dropdown there is no "Block Manager" option

@csossi
Copy link

csossi commented May 14, 2019

Verified in QA

"Block Manager" not appearing:
image

@csossi csossi removed their assignment May 14, 2019
@westonruter westonruter added this to the v1.2 milestone May 21, 2019
@swissspidy
Copy link
Collaborator Author

This has regressed, see #2904.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants