Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E Tests: Block Manager disabled #2904

Closed
swissspidy opened this issue Jul 26, 2019 · 1 comment · Fixed by #2937
Closed

E2E Tests: Block Manager disabled #2904

swissspidy opened this issue Jul 26, 2019 · 1 comment · Fixed by #2937
Assignees
@kienstra
Labels
Bug Something isn't working Needs Tests
Milestone
v1.2.1

Comments

@swissspidy
Copy link
Collaborator

Originally disabled in #2180, it seems that the Block Manager option is now visible again.

Let's fix this and add a proper test to verify that the option is not visible.
@swissspidy swissspidy added Bug Something isn't working Needs Tests AMP Stories labels Jul 26, 2019
@swissspidy swissspidy mentioned this issue Jul 26, 2019
Closed
@kienstra kienstra self-assigned this Aug 4, 2019
@kienstra kienstra mentioned this issue Aug 5, 2019
Merged
@swissspidy
Copy link
Collaborator Author

Looks like this regressed with the changes in WordPress/gutenberg#14843 (Gutenberg 5.9). This version was released mid-June, right before we published version 1.2 of the AMP plugin.

@swissspidy swissspidy added this to the v1.2.1 milestone Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kienstra kienstra

Labels
Bug Something isn't working Needs Tests
Projects
None yet
Milestone
v1.2.1
Development

Successfully merging a pull request may close this issue.

Hide the Block Manager and add an e2e test for it ampproject/amp-wp
2 participants
@swissspidy @kienstra