Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global Inserter looks broken on upstream develop branch #3062

Closed
miina opened this issue Aug 21, 2019 · 2 comments · Fixed by #3075
Closed

Global Inserter looks broken on upstream develop branch #3062

miina opened this issue Aug 21, 2019 · 2 comments · Fixed by #3075
Labels
Bug Something isn't working Integration: Gutenberg
Milestone
v1.2.1

Comments

@miina
Copy link
Contributor

miina commented Aug 21, 2019

Looks like some changes to the inserter style were implemented which look broken on AMP Stories:

Screenshot 2019-08-21 at 18 03 09

This change hasn't been released yet but we'll likely need to address this thinking of the release.
@miina miina added Bug Something isn't working AMP Stories Needs Testing Issues that need to be confirmed. labels Aug 21, 2019
@swissspidy swissspidy added Integration: Gutenberg and removed Needs Testing Issues that need to be confirmed. labels Aug 21, 2019
@miina miina mentioned this issue Aug 22, 2019
Merged
@miina miina added this to the v1.2.1 milestone Aug 22, 2019
@miina
Copy link
Contributor Author

miina commented Aug 22, 2019

Instructions for testing:

  • Open global block inserter
  • Verify that it doesn't look broken (see the description to see how it's not supposed to look like)

@csossi
Copy link

csossi commented Aug 22, 2019

Verified in QA:
image

@csossi csossi removed their assignment Aug 22, 2019
@swissspidy swissspidy mentioned this issue Oct 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working Integration: Gutenberg
Projects
None yet
Milestone
v1.2.1
Development

Successfully merging a pull request may close this issue.

Adjust block inserter style. ampproject/amp-wp
3 participants
@swissspidy @miina @csossi