Update versions tested in Travis build matrix #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
westonruter
commented
Apr 4, 2018
westonruter
commented
- Add PHP 7.2 to Travis test matrix; WordPress currently recommends PHP 7.2.
- Include testing PHP 5.6 (the most popular PHP version), as well as 5.5.
- Include testing WP 4.8 and trunk.
- Skip running PHPCS on every build; only needs to be run once.
- Clean up some PHPCS issues along the way to cause PHP to be checked in the build.
kienstra
suggested changes
Apr 4, 2018
There was a problem hiding this comment.
Nice PR, Minor Suggestion
Hi @westonruter,
This PR looks good. Travis should run faster now that PHPCS only runs once. There are also good DocBlock and coding style improvements.
There's a minor suggestion here, but it's fine otherwise.
wpcom-helper.php
Outdated
| * @param WP_Post $post Post. | ||
| * | ||
| * @return array Modified metadata array. | ||
| */ | ||
| function jetpack_amp_post_template_metadata( $metadata, $post ) { | ||
| if ( isset( $metadata['publisher'] ) && ! isset( $metadata['publisher']['logo'] ) ) { | ||
| $metadata = wpcom_amp_add_blavatar_to_metadata( $metadata, $post ); |
There was a problem hiding this comment.
It'd probably be good to remove the second $post argument of wpcom_amp_add_blavatar_to_metadata() here, as the function function now only accepts one argument.
There was a problem hiding this comment.
Good catch. Fixed in f683d9f.
| * | ||
| * @todo Move this into Jetpack. See https://github.com/Automattic/amp-wp/issues/1021 | ||
| * @package AMP | ||
| */ |
There was a problem hiding this comment.
Nice additions of DocBlocks and improvements in coding style here.
kienstra
approved these changes
Apr 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.