-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add theme support settings to admin screen; prevent serving dirty AMP #1199
Commits on Jun 6, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 5a81073 - Browse repository at this point
Copy the full SHA 5a81073View commit details -
Configuration menu - View commit details
-
Copy full SHA for 92424fb - Browse repository at this point
Copy the full SHA 92424fbView commit details -
Add options for enabling amp theme support and configuring validation…
… handling * Add admin settings for picking between disabled, paired, and native theme support. See #1196. * Add checkbox for automatically allowing tree shaking. * Add checkbox for automatically sanitizing all validation errors (including tree shaking). * Make explicitly clear that unaccepted validation errors will block rendering on AMP * Prevent serving dirty AMP by forcibly sanitizing all validation errors when amp_is_canonical(). See #1192. * When validation errors are automatically sanitized, ensure the terms' term_group is updated when re-checking. * Update AMP_Options_Manager::get_options() and to return default values.
Configuration menu - View commit details
-
Copy full SHA for 555c079 - Browse repository at this point
Copy the full SHA 555c079View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5bae33e - Browse repository at this point
Copy the full SHA 5bae33eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a5756d9 - Browse repository at this point
Copy the full SHA a5756d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0068e79 - Browse repository at this point
Copy the full SHA 0068e79View commit details -
Configuration menu - View commit details
-
Copy full SHA for be0557b - Browse repository at this point
Copy the full SHA be0557bView commit details
Commits on Jun 7, 2018
-
Configuration menu - View commit details
-
Copy full SHA for b94a830 - Browse repository at this point
Copy the full SHA b94a830View commit details -
Merge branch 'develop' of https://github.com/Automattic/amp-wp into a…
…dd/admin-theme-support-options
Configuration menu - View commit details
-
Copy full SHA for 0c339d9 - Browse repository at this point
Copy the full SHA 0c339d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9971e22 - Browse repository at this point
Copy the full SHA 9971e22View commit details -
Include HTML comment explaining that amphtml version is not available…
… (and why) * Indicate the count of validation errors that are blocking AMP from being available. * Allow passing URL string in addition to amp_invalid_url post to AMP_Invalid_URL_Post_Type::get_invalid_url_validation_errors().
Configuration menu - View commit details
-
Copy full SHA for 32a093e - Browse repository at this point
Copy the full SHA 32a093eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f864d67 - Browse repository at this point
Copy the full SHA f864d67View commit details
Commits on Jun 8, 2018
-
Introduce "Flagged" status for validation errors which are Rejected b…
…ut which are still forcibly sanitized * Fix PHP 5.3 error * Remove automatically setting amp_validation_error term_group based on forced status. * Let preview URL include development=1 flag.
Configuration menu - View commit details
-
Copy full SHA for d890b6c - Browse repository at this point
Copy the full SHA d890b6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ec95351 - Browse repository at this point
Copy the full SHA ec95351View commit details -
Configuration menu - View commit details
-
Copy full SHA for 365d571 - Browse repository at this point
Copy the full SHA 365d571View commit details -
Improve UI to reflect sanitization status when required
* Update post editor warnings to reflect when validation errors are forcibly sanitized but not explicitly accepted. * Allow tree shaking setting to be shown when in native mode. * Show notice when selecting native mode that sanitization is required. * Hide the preview button from the amp_invalid_url post if sanitization is required.
Configuration menu - View commit details
-
Copy full SHA for 4aac14b - Browse repository at this point
Copy the full SHA 4aac14bView commit details -
Add AMP link to admin bar with indication of AMP status and re-valida…
…te link Discontinue automatically-deleting an amp_invalid_url post when all errors are resolved.
Configuration menu - View commit details
-
Copy full SHA for 5c6b486 - Browse repository at this point
Copy the full SHA 5c6b486View commit details -
Configuration menu - View commit details
-
Copy full SHA for 616dad7 - Browse repository at this point
Copy the full SHA 616dad7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 421dc74 - Browse repository at this point
Copy the full SHA 421dc74View commit details