Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[amp-stories sub-task] CTA UI improvements #1636

Merged
merged 16 commits into from
Nov 22, 2018
Merged

[amp-stories sub-task] CTA UI improvements #1636

merged 16 commits into from
Nov 22, 2018

Commits on Nov 21, 2018

  1. 1562: Block insertion of cta layer in first amp story page

    @jacobschweitzer
    jacobschweitzer committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    4fa9923 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'amp-stories' into amp-story/1562

    @jacobschweitzer
    jacobschweitzer committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    f966c72 View commit details
    Browse the repository at this point in the history

  3. Fix blurred element issue when selecting AMP CTA child

    @jacobschweitzer
    jacobschweitzer committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    26776a7 View commit details
    Browse the repository at this point in the history

  4. Do not try to add class if no element exists

    @jacobschweitzer
    jacobschweitzer committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    3e90bd1 View commit details
    Browse the repository at this point in the history

  5. Add RichText template with placeholder

    @jacobschweitzer
    jacobschweitzer committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    3e1aac7 View commit details
    Browse the repository at this point in the history

  6. Remove template as it gives error on new CTA creation

    @jacobschweitzer
    jacobschweitzer committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    86c8209 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2018

  1. 1562: Use core/button as template

    @jacobschweitzer
    jacobschweitzer committed Nov 22, 2018
    Configuration menu
    Copy the full SHA
    6815d2a View commit details
    Browse the repository at this point in the history

  2. 1562: Use else if to prevent error when trying to remove block twice

    @jacobschweitzer
    jacobschweitzer committed Nov 22, 2018
    Configuration menu
    Copy the full SHA
    befd00e View commit details
    Browse the repository at this point in the history

  3. Use data-amp-selected attribute to identify parent CTA layer

    @jacobschweitzer
    jacobschweitzer committed Nov 22, 2018
    Configuration menu
    Copy the full SHA
    5211097 View commit details
    Browse the repository at this point in the history

  4. 1562: Update props instead of using block selector for AMP story cta … 

    …layer focus
    @jacobschweitzer
    jacobschweitzer committed Nov 22, 2018
    Configuration menu
    Copy the full SHA
    96aa5c6 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/amp-stories' into amp-story/1562

    @miina
    miina committed Nov 22, 2018
    Configuration menu
    Copy the full SHA
    16bf325 View commit details
    Browse the repository at this point in the history

  6. Add missing text domain.

    @miina
    miina committed Nov 22, 2018
    Configuration menu
    Copy the full SHA
    453441d View commit details
    Browse the repository at this point in the history

  7. 1562: Only add data-amp-selected to CTA layer

    @jacobschweitzer
    jacobschweitzer committed Nov 22, 2018
    Configuration menu
    Copy the full SHA
    703c0e5 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'amp-story/1562' of https://github.com/Automattic/amp-wp … 

    …into amp-story/1562
    @jacobschweitzer
    jacobschweitzer committed Nov 22, 2018
    Configuration menu
    Copy the full SHA
    b37d430 View commit details
    Browse the repository at this point in the history

  9. Improve CTA style.

    @miina
    miina committed Nov 22, 2018
    Configuration menu
    Copy the full SHA
    dae0bcb View commit details
    Browse the repository at this point in the history

  10. Add outline for CTA layer blocks, too.

    @miina
    miina committed Nov 22, 2018
    Configuration menu
    Copy the full SHA
    81a7459 View commit details
    Browse the repository at this point in the history