Remove admin-bar class name from body when admin bar element removed due to excessive CSS #2405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Themes have styles specific for when the admin bar is shown:
With #2346 the admin bar is now removed if the admin bar CSS is excessive. However, this removal did not include the removal of the
admin-bar
class from the body element. The results can be undesirable:The
admin-bar
class needs to be removed from thebody
in addition to thewpadminbar
element being removed from the DOM. With that change applied, the result is as expected:As noted in the comments, it would be nice if the style rules could be removed which have selectors referencing
.admin-bar
. But this would require doing a second pass at tree shaking, and it doesn't seem worthwhile since the number of styles removed is small.