Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix most pressing RTL issues #3558

Merged
merged 10 commits into from
Oct 25, 2019
Merged

Fix most pressing RTL issues #3558

merged 10 commits into from
Oct 25, 2019

Conversation

swissspidy
Copy link
Collaborator

@swissspidy swissspidy commented Oct 18, 2019 •
edited
Loading

Summary

See #3012

Issues resolved with this PR:

  • Editor carousel layout
  • Highlighted drag areas for cross-page dragging
  • CTA button form overlapping the button

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@googlebot googlebot added the cla: yes Signed the Google CLA label Oct 18, 2019
@swissspidy swissspidy mentioned this pull request Oct 21, 2019
Closed
4 tasks
@swissspidy swissspidy marked this pull request as ready for review October 23, 2019 13:08
@swissspidy swissspidy changed the title Experimental RTL Handling for Stories Editor Fix most pressing RTL issues Oct 23, 2019
@swissspidy swissspidy added this to the v1.4 milestone Oct 23, 2019
barklund
barklund reviewed Oct 24, 2019
View reviewed changes
Copy link
Contributor

@barklund barklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looks fine, but requires quite a bit of testing.

assets/src/stories-editor/components/editor-carousel/index.js Outdated Show resolved Hide resolved
assets/src/stories-editor/blocks/amp-story-cta/edit.css Show resolved Hide resolved
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no Has not signed the Google CLA and removed cla: yes Signed the Google CLA labels Oct 24, 2019
@barklund
Copy link
Contributor

@googlebot I consent.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Signed the Google CLA and removed cla: no Has not signed the Google CLA labels Oct 24, 2019
@swissspidy swissspidy merged commit 5489a2e into develop Oct 25, 2019
@swissspidy swissspidy deleted the fix/3012-rtl-styling branch October 25, 2019 09:41
westonruter added a commit that referenced this pull request Oct 25, 2019
@westonruter
Merge branch 'develop' of github.com:ampproject/amp-wp into add/query…
03a2395 
…-args-debugging

* 'develop' of github.com:ampproject/amp-wp: (163 commits)
  Remove entries array test after completed.
  Update dependency core-js to v3.3.4 (#3624)
  Quick UX fixes (#3611)
  Fix most pressing RTL issues (#3558)
  Add test case for broken parent relationship
  Adapt broken test
  Throw a _doing_it_wrong() when an expected parent is not found
  Change template hierarchy query arguments to public
  Reuse data-set-focus to reliably match twentytwenty keyboard focus management
  Add tabindex attribute to modals
  Guess the role of a modal based on its classes
  Disable Code Editor (#3608)
  Update dependency postcss to v7.0.20 (#3613)
  Update dependency autoprefixer to v9.7.0 (#3614)
  Update dependency browserslist to v4.7.2 (#3612)
  Add rel=preconnect link for AMP CDN
  Fix block nav padding and margin (#3610)
  Adjust Gutenberg / WordPress requirement (#3609)
  Don't allow multiple CTA / attachment block to be pasted. (#3601)
  Fix page crashing when duplicating immovable blocks (#3593)
  ...
@pierlon pierlon mentioned this pull request Nov 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barklund barklund barklund approved these changes

@westonruter westonruter Awaiting requested review from westonruter

Assignees
No one assigned
Labels
cla: yes Signed the Google CLA
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@swissspidy @googlebot @barklund