Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve admin bar validate link text #3605

Merged
merged 1 commit into from
Oct 23, 2019

Conversation

westonruter
Copy link
Member

@westonruter westonruter commented Oct 23, 2019

Summary

Under the AMP admin bar item:

  • Replace “Re-validate” with just “Validate”
  • Replace “Re-validate (%s validation errors)” with “Review %s validation issues”

In the post editor, the warning notice says “Review issues” so this use of issue aligns with that other usage. The word “issue” is less daunting than “error”, and the validation problem may not be an error on the site because its sanitization can be freely accepted.

See #2316.

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@westonruter westonruter added this to the v1.4 milestone Oct 23, 2019
@googlebot googlebot added the cla: yes Signed the Google CLA label Oct 23, 2019
Copy link
Member

@amedina amedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@westonruter westonruter merged commit faa1f8a into develop Oct 23, 2019
@westonruter westonruter deleted the update/admin-bar-validate-item-text branch October 23, 2019 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Signed the Google CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants