Remove obsolete meta viewport properties from v0.3 back-compat template #3690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Approved Hi @westonruter, |
kienstra
approved these changes
Nov 5, 2019
westonruter
deleted the
update/meta-viewport-in-v0.3-back-compat-templates
branch
westonruter
added a commit
that referenced
this pull request
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up on #3681. When I found out that the old meta viewport was added in the initial version of the plugin, I then realized that it also would need to be updated in the (very) old v0.3 back-compat templates (which we should really deprecate now, cf. #2202). This PR updates the the old meta viewport to remove the now-unnecessary meta viewport properties which cause a11y problems.
Checklist