Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent errors in admin bar filters from non-array arguments #4207

Merged
merged 3 commits into from
Jan 31, 2020
Merged

Prevent errors in admin bar filters from non-array arguments #4207

merged 3 commits into from
Jan 31, 2020

Commits on Jan 31, 2020

  1. Commit Weston's fix for the in_array() error, add small tests 

    Props @westonruter for the fix
Prevents running in_array() if the deps
are not an array.
    @kienstra
    kienstra committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    ff4375a View commit details
    Browse the repository at this point in the history

  2. Use actual $tag values passed from filters, though the domains are ch… 

    …anged

As Weston mentioned, this
ensures the test doesn't give false results.
    @kienstra
    kienstra committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    68964a4 View commit details
    Browse the repository at this point in the history

  3. Ignore a PHPCS error from non-enqueued assets

    @kienstra
    kienstra committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    f6f1fc2 View commit details
    Browse the repository at this point in the history