Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open story export instructions in a new window #4258

Merged
merged 1 commit into from
Feb 9, 2020

Conversation

westonruter
Copy link
Member

@westonruter westonruter commented Feb 9, 2020

Summary

  • Make export instructions open in a new window when clicked in the editor as well.

Amends #4219; see #4202.

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@westonruter westonruter added this to the v1.4.3 milestone Feb 9, 2020
@googlebot googlebot added the cla: yes Signed the Google CLA label Feb 9, 2020
Copy link
Member

@amedina amedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@westonruter
Copy link
Member Author

  • Make export instructions open in a new window when clicked in the editor as well.

I see no way to open editor notices in a new window:

https://github.com/WordPress/gutenberg/blob/f96c3d478caa423017354a72032af3a3bfb517a9/packages/notices/src/store/actions.js#L11-L18

@westonruter westonruter marked this pull request as ready for review February 9, 2020 19:48
@westonruter westonruter merged commit f77530f into develop Feb 9, 2020
@westonruter westonruter deleted the add/blank-window-story-export-instructions branch February 9, 2020 20:26
@pierlon
Copy link
Contributor

pierlon commented Feb 9, 2020

@westonruter Here's one way to open a new window in the editor:

--- includes/options/class-amp-options-manager.php	(revision f77530f809c88cea6310d3d669119e0a710e3b8b)
+++ includes/options/class-amp-options-manager.php	(date 1581284825580)
@@ -621,8 +621,9 @@
 								isDismissible: false,
 								actions: [
 									{
-										url: 'https://amp-wp.org/documentation/amp-stories/exporting-stories/',
 										label: %s,
+										className: 'is-link', // to make the <button> look like a link
+										onClick: () => window.open(\"https://amp-wp.org/documentation/amp-stories/exporting-stories/\")
 									},
 								],
 						    }

@csossi
Copy link

csossi commented Feb 13, 2020

Verified in QA

@csossi csossi added the QA passed Has passed QA and is done label Feb 13, 2020
westonruter added a commit that referenced this pull request Feb 13, 2020
* tag '1.4.3': (22 commits)
  Update readme and screenshots for Stories removal (#4259)
  Open story export instructions in a new window (#4258)
  Bump version to 1.4.3-RC1
  Hide Stories options and add deprecation notice (#4219)
  Fix malformed conversion of relative action URLs for forms (#4250)
  Limit Stories experience to WP 5.3 & Gutenberg 7.1.0 (#4217)
  Prevent errors in admin bar filters from non-array arguments (#4207)
  Update @wordpress/e2e-test-utils dependency
  Revert update of mustache/mustache dependency
  Update composer.lock
  Update WP CLI to 2.4.0
  For WordPress.tv embed, Use an oembed filter instead of block filter (#4164)
  Update readme to add FAQs section (#4159)
  Apply workaround to fix test__multiple_valid_image_files (#4034)
  Ignore Story editor tests (#4043)
  Update amp-video embed regex pattern to include other Vimeo URL formats (#4051)
  Update amp-instagram embed regex (#4053)
  Update wp-dev-lib package (#4029)
  Fix conversion of forms with relative action URLs (#4003)
  Improve release instructions (#3995)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Signed the Google CLA QA passed Has passed QA and is done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants