Allow the amp-carousel script to be used on page when there is just amp-lightbox-gallery
#6509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p-lightbox-gallery
westonruter
force-pushed
the
update/allow-amp-carousel-when-only-amp-lightbox-gallery-present
branch
from
a2008ae
to
972054a
Compare
|
Plugin builds for 972054a are ready 🛎️!
|
westonruter
deleted the
update/allow-amp-carousel-when-only-amp-lightbox-gallery-present
branch
westonruter
added a commit
that referenced
this pull request
Aug 3, 2021
…p-lightbox-gallery (#6509)
westonruter
added a commit
that referenced
this pull request
Aug 3, 2021
…image-dimension * 'develop' of github.com:ampproject/amp-wp: Allow the amp-carousel script to be on the page when there is just amp-lightbox-gallery (#6509) Mock HTTP request Supply non-empty body and headers for tests Only unserialize cached response if it is a string Update amp-twitter to use fixed-height layout with a default height matching minimal tweet height Bump eslint from 7.31.0 to 7.32.0 Use OVERFLOW constant Remove unused `use` statements Add overflow buttons to Twitter, Facebook, and Instagram embeds Pin amp-toolbox-php to specific commit in main Update amp-toolbox-php to 98b020d6 Remove unused AmpProject\Dom\Document imports Update references to renamed class constants and remove old deprecated code Update amp-toolbox-php to 0.7.0-alpha (main@a155c37) Update snapshot Use unique IDs for each SVG component instantiation Avoid redirect_extraneous_paired_endpoint from needlessly redirecting Revert "Prevent mutating URL when query var is absent" Prevent mutating URL when query var is absent
pierlon
pushed a commit
to pierlon/amp-wp
that referenced
this pull request
Aug 15, 2021
…p-lightbox-gallery (ampproject#6509)
|
QA Passed When adding the following plugin code: add_action( 'wp_enqueue_scripts', function () {
wp_enqueue_script('amp-carousel');
} );The If no image has the lightbox effect, then the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow the amp-carousel script as a special case to be on the page when there is no since the
amp-lightbox-gallery component will lazy-load the amp-carousel script when a lightbox is opened, and since
amp-carousel v0.1 is still the 'latest' version, this can mean that fixes needed with the 0.2 version won't
be present on the page. Adding the amp-carousel v0.2 script is a stated workaround suggested in an AMP core
issue: ampproject/amphtml#35402 (comment).
See also #3115 (comment).
Checklist