Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gutenberg packages after v14.7.3 release #7375

Closed
wants to merge 8 commits into from

Conversation

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Dec 15, 2022
@thelovekesh thelovekesh marked this pull request as draft December 15, 2022 03:20
@thelovekesh thelovekesh marked this pull request as ready for review December 15, 2022 03:20
@github-actions
Copy link
Contributor Author

github-actions bot commented Dec 15, 2022

Plugin builds for 0fe8217 are ready 🛎️!

@thelovekesh
Copy link
Collaborator

@westonruter Now that @wordpress/element is compatible with React 18, our build and test cases are failing.

Additionally, after bumping React to v18, test cases are still failing since they are still using render instead of createRoot in @wordpress/element, for which a PR has been created on the Gutenberg repository. (WordPress/gutenberg#46467)

In order to ensure that our test cases are unaffected in the event that React APIs change, I'll recommend using the React Testing Library for the tests. Please take a look at the test cases I changed with @testing-library/react. If everything appears to be in order, I'll go ahead and modify other test cases.

@westonruter
Copy link
Member

I'm not familiar with the details, but it sounds good to me!

@westonruter westonruter added this to the v2.3.1 milestone Dec 15, 2022
- Remove unsage of `render` from `@wordpress/element`
- Use `act` from `@testing-library/react` instead of `react-dom/test-utils`

- Update test cases for AMPDocumentStatusNotification component
- Update test cases for AMPRevalidateNotification component
- Update test cases for AMPValidationStatusNotification component
- Update test cases for Icons component
- Update test cases for SidebarNotification component
- Update test cases for SidebarNotificationsContainer component
- Update test cases for withAMPToolbarButton component
- Update test cases for useAMPDocumentToggle hook
- Update test cases for AMPToggle component
- Update test cases for Nav component
- Update test cases for ThemesContextProvider component
- Update test cases for TemplateModeOption component
- Update test cases for SiteScanSourcesList component
- Update test cases for Selectable component
- Update test cases for RedirectToggle component
- Update test cases for ProgressBar component
- Update test cases for PluginsContextProvider component
- Update test cases for NavMenu component
- Update test cases for Loading component
- Update test cases for DevToolsToggle component
- Update test cases for ConditionalDetails component
- Update test cases for AMPNotice component
- Update test cases for AMPSettingToggle component
- Update test cases for AmpAdminNotice component
- Update test cases for useValidationErrorStateUpdates hook
- Update test cases for usePostDirtyStateChanges hook
- Update test cases for Error component
- Update test cases for CarouselNav component
- Update test cases for useErrorsFetchingStateChanges hook
@thelovekesh thelovekesh force-pushed the update/gutenberg-v14.7.3-packages branch from 57cff29 to 1051a99 Compare December 16, 2022 18:32
@thelovekesh
Copy link
Collaborator

Closing in favor of PR 7394.

@thelovekesh thelovekesh closed this Jan 9, 2023
@westonruter westonruter modified the milestones: v2.3.1, v2.4 Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants