Fix deprecated _admin_bar_bump_cb; Fix failing PHP unit tests
#7635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thelovekesh
force-pushed
the
fix/admin-bar-styles
branch
from
941e2bd to
c6717cd
Compare
westonruter
reviewed
Oct 4, 2023
thelovekesh
force-pushed
the
fix/admin-bar-styles
branch
2 times, most recently
from
0a0fae6 to
30736fe
Compare
…iently Co-authored-by: Weston Ruter <westonruter@google.com>
thelovekesh
force-pushed
the
fix/admin-bar-styles
branch
from
9dc8eba to
1301315
Compare
|
Plugin builds for 82fe088 are ready 🛎️!
|
thelovekesh
force-pushed
the
fix/admin-bar-styles
branch
from
1301315 to
159a2e0
Compare
westonruter
reviewed
Oct 10, 2023
Comment on lines
551
to
561
| - name: Override default PHPUnit configuration | ||
| if: ${{ matrix.experimental == true && needs.pre-run.outputs.changed-php-count > 0 }} | ||
| run: | | ||
| cp phpunit.xml.dist phpunit.xml | ||
|
|
||
| # Avoid converting deprecations, errors, notices, and warnings to exceptions in experimental mode. | ||
| sed -i 's/convertDeprecationsToExceptions="true"/convertDeprecationsToExceptions="false"/g' phpunit.xml | ||
| sed -i 's/convertErrorsToExceptions="true"/convertErrorsToExceptions="false"/g' phpunit.xml | ||
| sed -i 's/convertNoticesToExceptions="true"/convertNoticesToExceptions="false"/g' phpunit.xml | ||
| sed -i 's/convertWarningsToExceptions="true"/convertWarningsToExceptions="false"/g' phpunit.xml | ||
| working-directory: ${{ env.WP_CORE_DIR }}/src/wp-content/plugins/amp |
Comment on lines
-278
to
+283
| return [ 'file' => $file ]; | ||
| $file = str_replace( '{{ get_template_directory }}', get_template_directory(), $file ); | ||
| $file = str_replace( '{{ get_stylesheet_directory }}', get_stylesheet_directory(), $file ); | ||
|
|
||
| return [ | ||
| 'file' => $file, | ||
| ]; |
| @@ -454,6 +459,7 @@ public function test_delete_transients( $using_ext_object_cache ) { | |||
| '_transient_foo', | |||
| '_transient_timeout_bar', | |||
| '_transient_timeout_baz', | |||
| '_transient_wp_theme_patterns_' . get_stylesheet(), | |||
There was a problem hiding this comment.
Good that you tested this is preserved.
westonruter
reviewed
Oct 10, 2023
| $this->assertFalse( has_action( 'wp_head', $callback ) ); | ||
| } | ||
|
|
||
| remove_action( 'wp_print_styles', 'print_emoji_styles' ); |
There was a problem hiding this comment.
Could you add a // comment after this and the other instances in this file just to explain why it is removed for future reference?
There was a problem hiding this comment.
Done in 82fe088.
There was a problem hiding this comment.
In default-filters.php in core now, it has:
add_action( 'admin_print_styles', 'print_emoji_styles' ); // Retained for backwards-compatibility. Unhooked by wp_enqueue_emoji_styles().So isn't this handled by wp_enqueue_emoji_styles()?
There was a problem hiding this comment.
is_admin() is false at this point.
Co-authored-by: Weston Ruter <westonruter@google.com>
westonruter
approved these changes
Oct 10, 2023
westonruter
added
the
Changelogged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7619
Checklist