Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update checkbox CSS #7844

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Update checkbox CSS #7844

merged 1 commit into from
Jul 15, 2024

Conversation

thelovekesh
Copy link
Collaborator

@thelovekesh thelovekesh commented Jul 14, 2024 •
edited
Loading

Summary

Fixes #7843

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@thelovekesh thelovekesh mentioned this pull request Jul 14, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 14, 2024 •
edited
Loading

Plugin builds for 7ff821d are ready 🛎️!

Checksums 
# Development build checksums
eb1a31afae0230ce557176cfeb36cff0b4cfc5a968c3ad9fcb0a8640a83f55f8 *amp.zip

# Production build checksums
1739887542ea99a0ca028eecdb48829be8d1731778d4c41931c9649f91525b9a *amp.zip

Warning

These builds are for testing purposes only and should not be used in production.

@thelovekesh thelovekesh force-pushed the update/checkbox-styles branch from 9c85575 to 7ff821d Compare July 14, 2024 18:14
@thelovekesh thelovekesh requested a review from westonruter July 14, 2024 18:32
@westonruter
Copy link
Member

How did you figure out that this was the required CSS to fix the issue?

Otherwise, LGTM so I'm approving, but noting that @pavanpatil1 will be testing as well.

@westonruter westonruter added this to the v2.5.4 milestone Jul 14, 2024
@thelovekesh
Copy link
Collaborator Author

How did you figure out that this was the required CSS to fix the issue?

We are updating the checkbox component appearance using our own CSS. I just inspected the styles and found the culprit.

@westonruter westonruter merged commit 80c0e0c into develop Jul 15, 2024
42 of 49 checks passed
@westonruter westonruter deleted the update/checkbox-styles branch July 15, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter Awaiting requested review from westonruter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.5.4
Development

Successfully merging this pull request may close these issues.

Checkbox icons are not properly visible
2 participants
@thelovekesh @westonruter