Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isset() check in case source type is absent #7864

Merged
merged 3 commits into from
Sep 3, 2024
Merged

Conversation

westonruter
Copy link
Member

@westonruter westonruter commented Aug 22, 2024

Fixes #7862

The only behavioral change in this PR is 66ca42e, the addition of an isset() check. (However, it's not clear why the key isn't set in the first place.)

Otherwise, it just bumps the minimum version of WP from 6.3 to 6.5 due to Gutenberg increasing its minimum required version of WP. And it fixes a test breakage due to a CSS change in the Twenty Ten theme.

@westonruter westonruter added the Bug Something isn't working label Aug 22, 2024
@westonruter westonruter added this to the v2.5.5 milestone Aug 22, 2024
Copy link
Contributor

github-actions bot commented Aug 22, 2024

Plugin builds for 296c233 are ready 🛎️!

Checksums
# Development build checksums
605861f2cf452475ee2454e1ab1f78c247be2ab844a6bc1de424c3283c4ca45f *amp.zip

# Production build checksums
6c603ea79356b948a7590dd3bc912a249a6a2c060c3e0bb2786400542db818e1 *amp.zip

Warning

These builds are for testing purposes only and should not be used in production.

@westonruter
Copy link
Member Author

Some of the tests are failing because Gutenberg is being installed on WP 6.3, but it requires WP 6.5+ now.

Other tests are failing (trivially) due to a CSS change.

@thelovekesh
Copy link
Collaborator

Also, need to config ig there is any redundant code added for backward compatibility for WP < 6.5. But that can be part of other PR if any.

@westonruter westonruter merged commit ad24bd7 into develop Sep 3, 2024
33 of 35 checks passed
@westonruter westonruter deleted the fix/isset-check branch September 3, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP error: Undefined array key "type" in class-amp-validation-manager.php on line 1169
2 participants