fixed In PHP, it's deprecated to pass a null value to the first param… #7947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eter ($string) which is of type string.
|
|
westonruter
requested changes
Dec 7, 2024
Comment on lines
583
to
584
| // 检查$path是否为null，若是则赋值为空字符串 | ||
| $path = $path?? ''; |
There was a problem hiding this comment.
Suggested change
| // 检查$path是否为null，若是则赋值为空字符串 | |
| $path = $path?? ''; | |
| if ( null === $path ) { | |
| return false; | |
| } |
There was a problem hiding this comment.
Thank you very much for taking the time to review my PR and providing such valuable suggestions. I really appreciate.
…() function raises a deprecation warning. Specifically, passing null to parameter
westonruter
reviewed
Dec 8, 2024
| @@ -580,6 +580,10 @@ private function maybe_add_lightbox_attributes( $attributes, $node ) { | |||
| private function is_gif_url( $url ) { | |||
| $ext = self::$anim_extension; | |||
| $path = wp_parse_url( $url, PHP_URL_PATH ); | |||
| // 检查$path是否为null，若是则赋值为空字符串 | |||
There was a problem hiding this comment.
For this project, code comments are in English. In any case, no need for a comment here since the reason is self-explanatory:
Suggested change
| // 检查$path是否为null，若是则赋值为空字符串 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In PHP version 8.2, an issue has been identified where the substr() function raises a deprecation warning. Specifically, passing null to parameter #1 ($string) which is of type string is now deprecated. This problem occurs on line 583 of the file
Fixes
Our code in this pull request aims to address this deprecation issue by ensuring that a valid non-null string value is passed to the relevant parameter within the substr() function call, thereby making the code compliant with the requirements of PHP 8.2 and avoiding the appearance of such deprecation warnings.
Checklist