Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#796 Move AMP Customizer into main Customizer #819

Merged
merged 27 commits into from
Dec 12, 2017
Merged

#796 Move AMP Customizer into main Customizer #819

merged 27 commits into from
Dec 12, 2017

Commits on Dec 6, 2017

  1. Move AMP Customizer into main Customizer to expand usability across a… 

    …ll posts and pages.
    @kaitnyl
    kaitnyl committed Dec 6, 2017
    Configuration menu
    Copy the full SHA
    2ea1341 View commit details
    Browse the repository at this point in the history

  2. Fix amp_get_permalink() for permalinks containing query params (e.g. … 

    …draft and previews)

* Use query var in permalinks containing query vars, instead of endpoint slug.
* Remove needless and unslightly 1 value.
* Add tests.
    @westonruter
    westonruter committed Dec 6, 2017
    Configuration menu
    Copy the full SHA
    0885b48 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2017

  1. Use AMP_QUERY_VAR in regex to identify/alter AMP URLs.

    @kaitnyl
    kaitnyl committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    942a1fa View commit details
    Browse the repository at this point in the history

  2. Make use of wp.template for adding HTML to Customizer and include tra… 

    …nslatable tooltip strings.
    @kaitnyl
    kaitnyl committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    9f34b14 View commit details
    Browse the repository at this point in the history

  3. Move away from referencing input status and use wp.customize.state to… 

    … control UI.
    @kaitnyl
    kaitnyl committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    d6159ab View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2017

  1. Detect if page can be AMP'd from within Previewer and control toggle … 

    …availability.
    @kaitnyl
    kaitnyl committed Dec 8, 2017
    Configuration menu
    Copy the full SHA
    a716482 View commit details
    Browse the repository at this point in the history

  2. Use alternative to regex to check if AMP is within query string, and … 

    …enable AMP toggle if users selects mobile device.
    @kaitnyl
    kaitnyl committed Dec 8, 2017
    Configuration menu
    Copy the full SHA
    65bf04a View commit details
    Browse the repository at this point in the history

  3. Avoid using wp_localize_script() to send data.

    @kaitnyl
    kaitnyl committed Dec 8, 2017
    Configuration menu
    Copy the full SHA
    0679cb2 View commit details
    Browse the repository at this point in the history

  4. Move amp_customizer_is_enabled filter to only control UI elements wit… 

    …hin Customizer.
    @kaitnyl
    kaitnyl committed Dec 8, 2017
    Configuration menu
    Copy the full SHA
    0d1790b View commit details
    Browse the repository at this point in the history

  5. JSHint updates.

    @kaitnyl
    kaitnyl committed Dec 8, 2017
    Configuration menu
    Copy the full SHA
    7e23ff2 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'develop' into feature/796-amp-customizer

    @kaitnyl
    kaitnyl committed Dec 8, 2017
    Configuration menu
    Copy the full SHA
    05e2a58 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2017

  1. Fix eslint errors

    @westonruter
    westonruter committed Dec 9, 2017
    Configuration menu
    Copy the full SHA
    4507a04 View commit details
    Browse the repository at this point in the history

  2. Fix live preview of color changes 

    * Include more Customizer preview logic from manager in AMP preview
* Ensure scripts and styles are enqueued when preview opened for controls app; this ensures AMP validation can pass when using frontend preview link.
* Restore previous add_preview_scripts method.
* Include more logic behind
* Add PHP doc.
* Improve WPCS adherence.
* Skip outputting Customizer preview JS if user cannot customize.
* Use wp_print_footer_scripts()` instead of doing wp_footer.
    @westonruter
    westonruter committed Dec 9, 2017
    Configuration menu
    Copy the full SHA
    7b56889 View commit details
    Browse the repository at this point in the history

  3. WIP: Fix styles

    @westonruter
    westonruter committed Dec 9, 2017
    Configuration menu
    Copy the full SHA
    b2f0b4b View commit details
    Browse the repository at this point in the history

  4. Fix retrieval of customized settings when Customizer is not bootstrapped

    @westonruter
    westonruter committed Dec 9, 2017
    Configuration menu
    Copy the full SHA
    c349320 View commit details
    Browse the repository at this point in the history

  5. Add selective refresh of header-bar to customizer preview 

    Fix obsolete method references and improve placement of add_action() calls
    @westonruter
    westonruter committed Dec 9, 2017
    Configuration menu
    Copy the full SHA
    df26de5 View commit details
    Browse the repository at this point in the history

  6. Add partial for footer; do wptexturize on title in header and footer;… 

    … prevent fallback refreshes
    @westonruter
    westonruter committed Dec 9, 2017
    Configuration menu
    Copy the full SHA
    e0c61f5 View commit details
    Browse the repository at this point in the history

  7. Improve behavior of AMP toggle when loading initially-AMPed URL in pr… 

    …eview

* Ensure that AMP Customizer preview JS is loaded in AMP and non-AMP mode so that the amp-status can be sent in each case.
* Enable AMP when clicking toggle and navigating to an AMPed post.
* Ensure password-protected posts are no returned by amp_admin_get_preview_permalink()
* Add screen-reader-text CSS rule to AMP styles.
* Move JS template vars into PHP-rendered template to simplify.
    @westonruter
    westonruter committed Dec 9, 2017
    Configuration menu
    Copy the full SHA
    d595bc9 View commit details
    Browse the repository at this point in the history

  8. Update AMP Customizer admin menu link to set initial URL for amped post

    @westonruter
    westonruter committed Dec 9, 2017
    Configuration menu
    Copy the full SHA
    556cacf View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2017

  1. Restrict screen-reader-text to Customizer preview styles 

    Also use AMP_QUERY_VAR instaed of hard-coded 'amp' in amp_admin_get_preview_permalink()
    @westonruter
    westonruter committed Dec 10, 2017
    Configuration menu
    Copy the full SHA
    a38d024 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2017

  1. Merge branch 'develop' of https://github.com/Automattic/amp-wp into f… 

    …eature/796-amp-customizer
    @westonruter
    westonruter committed Dec 11, 2017
    Configuration menu
    Copy the full SHA
    babf16c View commit details
    Browse the repository at this point in the history

  2. Remove deprecated and obsolete calls to amp_load_classes()

    @westonruter
    westonruter committed Dec 11, 2017
    Configuration menu
    Copy the full SHA
    083c9b3 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2017

  1. Let link in AMP toggle be regular link with href

    @westonruter
    westonruter committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    64f14be View commit details
    Browse the repository at this point in the history

  2. Add accessibility to AMP toggle; auto-show tooltip when navigating to… 

    … unavailable URL
    @westonruter
    westonruter committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    219f481 View commit details
    Browse the repository at this point in the history

  3. Only show tooltip upon unavailable if AMP is enabled. 

    * Remove linebreak from tooltip for alignment with autosave restore notification; tweak copy.
* Move functions from inside panel ready callback to component.
* Improve styling in AMP when unloading page.
    @westonruter
    westonruter committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    7308a9c View commit details
    Browse the repository at this point in the history

  4. Show AMP unavailable tooltip when expanding AMP panel and not on AMP-… 

    …compatible URL

Improve styling of link in tooltip to improve color contrast
    @westonruter
    westonruter committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    79297bf View commit details
    Browse the repository at this point in the history

  5. Disable AMP when switching away from mobile

    @westonruter
    westonruter committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    b1fa356 View commit details
    Browse the repository at this point in the history