-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sanitize invalid JSON script #893
Commits on Jan 23, 2018
-
Address an issue where <script> tags weren't stripped.
As Weston mentioned, adding this to the post content: Hello <script>document.write('world');</script> Produced: This looks to be related to how process_node() gets the $attr_spec_list. In some cases, all will have an equal 'score,' As indicated in $spec_ids_sorted. And sometimes, all of them will be missing a mandatory attribute. In that case, $attr_spec_list will be empty. If it is, use the first spec list in: $rule_spec_list_to_validate. This will need regression testing.
Ryan Kienstra committedJan 23, 2018 Configuration menu - View commit details
-
Copy full SHA for e2f7d2e - Browse repository at this point
Copy the full SHA e2f7d2eView commit details -
Address a Travis issue by storing the result of empty() in a variable.
There was an error on the Travis build: Can't use function return value in write context. So store the result of reset() in $first_spec_list.
Ryan Kienstra committedJan 23, 2018 Configuration menu - View commit details
-
Copy full SHA for c5f5168 - Browse repository at this point
Copy the full SHA c5f5168View commit details -
Test that <script> is removed, as it is missing an attribute.
This has a mandatory attribute. And per the previous commits, It should fail validation.
Ryan Kienstra committedJan 23, 2018 Configuration menu - View commit details
-
Copy full SHA for 335d9ce - Browse repository at this point
Copy the full SHA 335d9ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for f6ef76e - Browse repository at this point
Copy the full SHA f6ef76eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 86bdf13 - Browse repository at this point
Copy the full SHA 86bdf13View commit details
Commits on Jan 24, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 17f63ac - Browse repository at this point
Copy the full SHA 17f63acView commit details -
Configuration menu - View commit details
-
Copy full SHA for d25e48f - Browse repository at this point
Copy the full SHA d25e48fView commit details -
Merge pull request #892 from Automattic/fix/script-tags-output-cdata
Address an issue where <script> tags aren't stripped.
Configuration menu - View commit details
-
Copy full SHA for 0e494a7 - Browse repository at this point
Copy the full SHA 0e494a7View commit details -
Merge branch '0.6' of https://github.com/Automattic/amp-wp into fix/s…
…anitize-invalid-script-json
Configuration menu - View commit details
-
Copy full SHA for ce01d7f - Browse repository at this point
Copy the full SHA ce01d7fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f436e29 - Browse repository at this point
Copy the full SHA f436e29View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3bd1b7b - Browse repository at this point
Copy the full SHA 3bd1b7bView commit details -
1
Configuration menu - View commit details
-
Copy full SHA for bd6d401 - Browse repository at this point
Copy the full SHA bd6d401View commit details -
Configuration menu - View commit details
-
Copy full SHA for cceaffb - Browse repository at this point
Copy the full SHA cceaffbView commit details -
Merge branch '0.6' of https://github.com/Automattic/amp-wp into fix/s…
…anitize-invalid-script-json
Configuration menu - View commit details
-
Copy full SHA for fa666c7 - Browse repository at this point
Copy the full SHA fa666c7View commit details