-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.6 Release to master #896
Commits on Nov 23, 2017
-
Configuration menu - View commit details
-
Copy full SHA for c156501 - Browse repository at this point
Copy the full SHA c156501View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5499ba6 - Browse repository at this point
Copy the full SHA 5499ba6View commit details -
Configuration menu - View commit details
-
Copy full SHA for c5d0c99 - Browse repository at this point
Copy the full SHA c5d0c99View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b63cd5 - Browse repository at this point
Copy the full SHA 1b63cd5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2949f25 - Browse repository at this point
Copy the full SHA 2949f25View commit details -
Configuration menu - View commit details
-
Copy full SHA for d66bc62 - Browse repository at this point
Copy the full SHA d66bc62View commit details -
Configuration menu - View commit details
-
Copy full SHA for 99e7bcf - Browse repository at this point
Copy the full SHA 99e7bcfView commit details
Commits on Nov 24, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 68c5017 - Browse repository at this point
Copy the full SHA 68c5017View commit details -
Configuration menu - View commit details
-
Copy full SHA for dcadc4f - Browse repository at this point
Copy the full SHA dcadc4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c647dcf - Browse repository at this point
Copy the full SHA c647dcfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 600281d - Browse repository at this point
Copy the full SHA 600281dView commit details
Commits on Nov 27, 2017
-
Configuration menu - View commit details
-
Copy full SHA for ae8a3bb - Browse repository at this point
Copy the full SHA ae8a3bbView commit details
Commits on Nov 28, 2017
-
Configuration menu - View commit details
-
Copy full SHA for cdf9058 - Browse repository at this point
Copy the full SHA cdf9058View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f82014 - Browse repository at this point
Copy the full SHA 0f82014View commit details
Commits on Dec 1, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 779f763 - Browse repository at this point
Copy the full SHA 779f763View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce391a0 - Browse repository at this point
Copy the full SHA ce391a0View commit details
Commits on Dec 3, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 073308c - Browse repository at this point
Copy the full SHA 073308cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e4f6c87 - Browse repository at this point
Copy the full SHA e4f6c87View commit details -
Configuration menu - View commit details
-
Copy full SHA for f630062 - Browse repository at this point
Copy the full SHA f630062View commit details -
Configuration menu - View commit details
-
Copy full SHA for fdc26b3 - Browse repository at this point
Copy the full SHA fdc26b3View commit details
Commits on Dec 5, 2017
-
804 : Update allowed AMP tags in sanitizer file.
Generate class-amp-allowed-tags-generated.php, Using amp_wp_build.py. Followed the instructions at the top of the file. This is spec file revision 527.
Ryan Kienstra committedDec 5, 2017 Configuration menu - View commit details
-
Copy full SHA for 0b987a6 - Browse repository at this point
Copy the full SHA 0b987a6View commit details -
804 : Prevent errors on amp_wp_build.py, update extensions dir.
Before, there was an error in: tag_spec.also_requires_tag This didn't always have the property. Also, update the directory of the extensions. The .protoascii file is no longer in the directory '0.1.'
Ryan Kienstra committedDec 5, 2017 Configuration menu - View commit details
-
Copy full SHA for 30064ca - Browse repository at this point
Copy the full SHA 30064caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b0e1cd - Browse repository at this point
Copy the full SHA 5b0e1cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1befc79 - Browse repository at this point
Copy the full SHA 1befc79View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6df01e9 - Browse repository at this point
Copy the full SHA 6df01e9View commit details
Commits on Dec 6, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 5ea54e9 - Browse repository at this point
Copy the full SHA 5ea54e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad7c36b - Browse repository at this point
Copy the full SHA ad7c36bView commit details -
Move AMP Customizer into main Customizer to expand usability across a…
…ll posts and pages.
Configuration menu - View commit details
-
Copy full SHA for 2ea1341 - Browse repository at this point
Copy the full SHA 2ea1341View commit details -
Configuration menu - View commit details
-
Copy full SHA for febd02d - Browse repository at this point
Copy the full SHA febd02dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 63a60bd - Browse repository at this point
Copy the full SHA 63a60bdView commit details -
Create is_mandatory_attribute_missing method
Ryan Kienstra committedDec 6, 2017 Configuration menu - View commit details
-
Copy full SHA for ba459a2 - Browse repository at this point
Copy the full SHA ba459a2View commit details -
Fix amp_get_permalink() for permalinks containing query params (e.g. …
…draft and previews) * Use query var in permalinks containing query vars, instead of endpoint slug. * Remove needless and unslightly 1 value. * Add tests.
Configuration menu - View commit details
-
Copy full SHA for 0885b48 - Browse repository at this point
Copy the full SHA 0885b48View commit details -
Configuration menu - View commit details
-
Copy full SHA for 832c13b - Browse repository at this point
Copy the full SHA 832c13bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b922cb - Browse repository at this point
Copy the full SHA 3b922cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c14063 - Browse repository at this point
Copy the full SHA 8c14063View commit details -
Merge pull request #811 from Automattic/feature/789-cpt-admin-settings
Add admin screen for managing which post types have AMP support
Configuration menu - View commit details
-
Copy full SHA for c73f479 - Browse repository at this point
Copy the full SHA c73f479View commit details -
Merge branch 'develop' of https://github.com/Automattic/amp-wp into f…
…eature/709-block-amp-per-page
Configuration menu - View commit details
-
Copy full SHA for e66e2b2 - Browse repository at this point
Copy the full SHA e66e2b2View commit details -
Load JS for AMP post meta box if post type supports not if post is no…
…t skipped. * Restore focus on edit link for AMP status edit for accessibility. * Do not add AMP preview button if AMP has been disabled. * Change postmeta to be flag indicating whether AMP is disabled. * Fix spelling and clean up phpdoc.
Configuration menu - View commit details
-
Copy full SHA for 4f58949 - Browse repository at this point
Copy the full SHA 4f58949View commit details
Commits on Dec 7, 2017
-
Use queried object in amp_render() and allow passing post object to A…
…MP_Post_Template for sake of preview
Configuration menu - View commit details
-
Copy full SHA for 18ab955 - Browse repository at this point
Copy the full SHA 18ab955View commit details -
Configuration menu - View commit details
-
Copy full SHA for ced9461 - Browse repository at this point
Copy the full SHA ced9461View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1134bb1 - Browse repository at this point
Copy the full SHA 1134bb1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c5074e - Browse repository at this point
Copy the full SHA 5c5074eView commit details -
804 : Modify PHPUnit tests for tag and attribute validation.
Since the allowed tags and attributes are updated, Several assertions failed. Update them to reflect the new AMP spec. Since there is no longer a protocol whitelist, Remove the assertions for protocols.
Ryan Kienstra committedDec 7, 2017 Configuration menu - View commit details
-
Copy full SHA for 8cff768 - Browse repository at this point
Copy the full SHA 8cff768View commit details -
804 : Remove the requirement that 'data-multi-size' be empty.
This file was generated from a build script, In the repo https://github.com/ampproject/amphtml The spec file seems to require an empty value: extensions/amp-ad/validator-amp-ad.protoascii But examples of <amp-ad> seem to have the value. Like <amp-ad data-multi-size=320x50. @see examples/a4a-multisize.amp.html. So remove the line in the PHP file that requires it to be empty.
Ryan Kienstra committedDec 7, 2017 Configuration menu - View commit details
-
Copy full SHA for dd807a8 - Browse repository at this point
Copy the full SHA dd807a8View commit details -
804 : PHPUnit tests for newly-allowed tags.
Having generated a new file for the allowed tags and attributes, Add these to the data for test_sanitizer(). Also, add unit test for is_missing_mandatory_attribute(). And rename that function from: is_mandatory_attribute_missing().
Ryan Kienstra committedDec 7, 2017 Configuration menu - View commit details
-
Copy full SHA for a698eea - Browse repository at this point
Copy the full SHA a698eeaView commit details -
804 : Move logic for missing attributes.
Before, this was inside an 'else' block. And it should be outside of this, So it applies more broadly. If there is a list of attributes, and one is missing, Remove the node. This was the previous behavior.
Ryan Kienstra committedDec 7, 2017 Configuration menu - View commit details
-
Copy full SHA for a066117 - Browse repository at this point
Copy the full SHA a066117View commit details -
804 : Remove the unused $spec_value variable.
This was assigned a value that's used later. There's no need to store it in a variable.
Ryan Kienstra committedDec 7, 2017 Configuration menu - View commit details
-
Copy full SHA for cfcf730 - Browse repository at this point
Copy the full SHA cfcf730View commit details -
804 : Improve variable alignment and add PHPDoc tags.
There was some missing documentation. Add this for test_sanitizer and validate_tag_spec_for_node.
Ryan Kienstra committedDec 7, 2017 Configuration menu - View commit details
-
Copy full SHA for 8f0a925 - Browse repository at this point
Copy the full SHA 8f0a925View commit details -
Configuration menu - View commit details
-
Copy full SHA for 802bcfb - Browse repository at this point
Copy the full SHA 802bcfbView commit details -
804 : Exclude the generated allowed tags file from PHPCS checks.
This has hundreds of errors and warnings. It's generated from a Python script.
Ryan Kienstra committedDec 7, 2017 Configuration menu - View commit details
-
Copy full SHA for a400fa5 - Browse repository at this point
Copy the full SHA a400fa5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b6cc54 - Browse repository at this point
Copy the full SHA 1b6cc54View commit details -
804 : Align 'array' keywords vertically.
In response to the warnings in Travis. And align an equal sign in test_sanitizer().
Ryan Kienstra committedDec 7, 2017 Configuration menu - View commit details
-
Copy full SHA for cfc0247 - Browse repository at this point
Copy the full SHA cfc0247View commit details -
804 : Change the conditional to simply compare to true.
Before, there was a failed Travis build. This used boolval(), which caused a fatal error. Instead, simply compare the value to true.
Ryan Kienstra committedDec 7, 2017 Configuration menu - View commit details
-
Copy full SHA for 7f9a2db - Browse repository at this point
Copy the full SHA 7f9a2dbView commit details -
804 : Array and equal sign alignment fixes.
In response to a failed Travis build. Fix an error in an array not being aligned. An move an = sign 2 spaces to the left.
Ryan Kienstra committedDec 7, 2017 Configuration menu - View commit details
-
Copy full SHA for b4bfd81 - Browse repository at this point
Copy the full SHA b4bfd81View commit details -
804 : Prevent accessing an object as an array.
There was an error in the Travis build. A function accessed a DOMElement property as an array. Instead, use the setAttribute() method.
Ryan Kienstra committedDec 7, 2017 Configuration menu - View commit details
-
Copy full SHA for 6f5e39d - Browse repository at this point
Copy the full SHA 6f5e39dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 942a1fa - Browse repository at this point
Copy the full SHA 942a1faView commit details -
Make use of wp.template for adding HTML to Customizer and include tra…
…nslatable tooltip strings.
Configuration menu - View commit details
-
Copy full SHA for 9f34b14 - Browse repository at this point
Copy the full SHA 9f34b14View commit details -
Configuration menu - View commit details
-
Copy full SHA for d6159ab - Browse repository at this point
Copy the full SHA d6159abView commit details -
Merge pull request #813 from Automattic/feature/709-block-amp-per-page
Add post preview for AMP and allow AMP to be disabled on a per-post basis
Configuration menu - View commit details
-
Copy full SHA for eeb502b - Browse repository at this point
Copy the full SHA eeb502bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b4de15 - Browse repository at this point
Copy the full SHA 6b4de15View commit details
Commits on Dec 8, 2017
-
Fix amp_get_permalink() for permalinks containing query params (e.g. …
…draft and previews) * Use query var in permalinks containing query vars, instead of endpoint slug. * Remove needless and unslightly 1 value. * Add tests.
Configuration menu - View commit details
-
Copy full SHA for c5231b0 - Browse repository at this point
Copy the full SHA c5231b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for dcf7eb1 - Browse repository at this point
Copy the full SHA dcf7eb1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a76316 - Browse repository at this point
Copy the full SHA 3a76316View commit details -
Show AMP as disabled without UI to make enabled if post is password p…
…rotected or skipped
Configuration menu - View commit details
-
Copy full SHA for 2ae58d2 - Browse repository at this point
Copy the full SHA 2ae58d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7221f4 - Browse repository at this point
Copy the full SHA e7221f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 51c5b17 - Browse repository at this point
Copy the full SHA 51c5b17View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5dd2bc6 - Browse repository at this point
Copy the full SHA 5dd2bc6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b1443e - Browse repository at this point
Copy the full SHA 2b1443eView commit details -
Added classmap autoloader, removed all require_once(), deprecated amp…
…_load_classes() and amp_load_fasterimage_classes(), created /include/templates/ directory for template-related classes, and Options Manager out of the views subdirectory.
Configuration menu - View commit details
-
Copy full SHA for 8346524 - Browse repository at this point
Copy the full SHA 8346524View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c1fa20 - Browse repository at this point
Copy the full SHA 5c1fa20View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33c0ebf - Browse repository at this point
Copy the full SHA 33c0ebfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 08bac6b - Browse repository at this point
Copy the full SHA 08bac6bView commit details -
Removed 2nd parameter to remove_shortcode() because remove_shortcode(…
…) does not accept a 2nd parameter.
Configuration menu - View commit details
-
Copy full SHA for e5c1a8c - Browse repository at this point
Copy the full SHA e5c1a8cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b267ef - Browse repository at this point
Copy the full SHA 8b267efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b34e24 - Browse repository at this point
Copy the full SHA 8b34e24View commit details -
Configuration menu - View commit details
-
Copy full SHA for 57f5849 - Browse repository at this point
Copy the full SHA 57f5849View commit details -
Configuration menu - View commit details
-
Copy full SHA for c73f92b - Browse repository at this point
Copy the full SHA c73f92bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f67041d - Browse repository at this point
Copy the full SHA f67041dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 236968b - Browse repository at this point
Copy the full SHA 236968bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 269b937 - Browse repository at this point
Copy the full SHA 269b937View commit details -
Configuration menu - View commit details
-
Copy full SHA for a716482 - Browse repository at this point
Copy the full SHA a716482View commit details -
Use alternative to regex to check if AMP is within query string, and …
…enable AMP toggle if users selects mobile device.
Configuration menu - View commit details
-
Copy full SHA for 65bf04a - Browse repository at this point
Copy the full SHA 65bf04aView commit details -
Configuration menu - View commit details
-
Copy full SHA for cff791e - Browse repository at this point
Copy the full SHA cff791eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9630709 - Browse repository at this point
Copy the full SHA 9630709View commit details -
Include fallback error message for when all known reasons for unavail…
…ability are exhausted
Configuration menu - View commit details
-
Copy full SHA for 34a0e9e - Browse repository at this point
Copy the full SHA 34a0e9eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0679cb2 - Browse repository at this point
Copy the full SHA 0679cb2View commit details -
Merge pull request #825 from Automattic/feature/176-page-support
Add page support
Configuration menu - View commit details
-
Copy full SHA for edd7a40 - Browse repository at this point
Copy the full SHA edd7a40View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d1790b - Browse repository at this point
Copy the full SHA 0d1790bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e23ff2 - Browse repository at this point
Copy the full SHA 7e23ff2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 05e2a58 - Browse repository at this point
Copy the full SHA 05e2a58View commit details
Commits on Dec 9, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 4507a04 - Browse repository at this point
Copy the full SHA 4507a04View commit details -
804 : Add a contributing.md file, with steps to use build script.
This describes how to use the new script amphtml-update.sh. This is mainly modified from another open-source file. It could probably use more information. Including the workflow for submitting pull requests.
Ryan Kienstra committedDec 9, 2017 Configuration menu - View commit details
-
Copy full SHA for eab6207 - Browse repository at this point
Copy the full SHA eab6207View commit details -
Fix live preview of color changes
* Include more Customizer preview logic from manager in AMP preview * Ensure scripts and styles are enqueued when preview opened for controls app; this ensures AMP validation can pass when using frontend preview link. * Restore previous add_preview_scripts method. * Include more logic behind * Add PHP doc. * Improve WPCS adherence. * Skip outputting Customizer preview JS if user cannot customize. * Use wp_print_footer_scripts()` instead of doing wp_footer.
Configuration menu - View commit details
-
Copy full SHA for 7b56889 - Browse repository at this point
Copy the full SHA 7b56889View commit details -
Configuration menu - View commit details
-
Copy full SHA for b2f0b4b - Browse repository at this point
Copy the full SHA b2f0b4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c349320 - Browse repository at this point
Copy the full SHA c349320View commit details -
Add selective refresh of header-bar to customizer preview
Fix obsolete method references and improve placement of add_action() calls
Configuration menu - View commit details
-
Copy full SHA for df26de5 - Browse repository at this point
Copy the full SHA df26de5View commit details -
Add partial for footer; do wptexturize on title in header and footer;…
… prevent fallback refreshes
Configuration menu - View commit details
-
Copy full SHA for e0c61f5 - Browse repository at this point
Copy the full SHA e0c61f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b54243b - Browse repository at this point
Copy the full SHA b54243bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 38cccab - Browse repository at this point
Copy the full SHA 38cccabView commit details -
Configuration menu - View commit details
-
Copy full SHA for f13c385 - Browse repository at this point
Copy the full SHA f13c385View commit details -
Configuration menu - View commit details
-
Copy full SHA for 03c126b - Browse repository at this point
Copy the full SHA 03c126bView commit details -
Configuration menu - View commit details
-
Copy full SHA for fdd1c74 - Browse repository at this point
Copy the full SHA fdd1c74View commit details -
Configuration menu - View commit details
-
Copy full SHA for 48c492e - Browse repository at this point
Copy the full SHA 48c492eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a0b53c - Browse repository at this point
Copy the full SHA 1a0b53cView commit details -
Renamed _build_placeholder() back to build_placeholder() since no whe…
…re else is using the leading underscore convention for private methods.
Configuration menu - View commit details
-
Copy full SHA for fb10624 - Browse repository at this point
Copy the full SHA fb10624View commit details -
Configuration menu - View commit details
-
Copy full SHA for 19b6f04 - Browse repository at this point
Copy the full SHA 19b6f04View commit details -
Improve behavior of AMP toggle when loading initially-AMPed URL in pr…
…eview * Ensure that AMP Customizer preview JS is loaded in AMP and non-AMP mode so that the amp-status can be sent in each case. * Enable AMP when clicking toggle and navigating to an AMPed post. * Ensure password-protected posts are no returned by amp_admin_get_preview_permalink() * Add screen-reader-text CSS rule to AMP styles. * Move JS template vars into PHP-rendered template to simplify.
Configuration menu - View commit details
-
Copy full SHA for d595bc9 - Browse repository at this point
Copy the full SHA d595bc9View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1ee243 - Browse repository at this point
Copy the full SHA b1ee243View commit details -
Configuration menu - View commit details
-
Copy full SHA for 010dad4 - Browse repository at this point
Copy the full SHA 010dad4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 556cacf - Browse repository at this point
Copy the full SHA 556cacfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8fad986 - Browse repository at this point
Copy the full SHA 8fad986View commit details -
804 : Test that 'amp-playbuzz' is sanitized properly.
As harrisdavid mentioned, before this PR, the 'src' was mandatory. But with the updated AMP spec, it's not.
Ryan Kienstra committedDec 9, 2017 Configuration menu - View commit details
-
Copy full SHA for eef4b8b - Browse repository at this point
Copy the full SHA eef4b8bView commit details -
804 : Add allowed protocols to sanitization file.
Before, there was an issue in the file that created: class-amp-allowed-tags-generated.php. amphtml-update.sh had a conditional: if isinstance(value, list) But the allowed_protocol attribute has a type of: google.protobuf.internal.containers.RepeatedScalarFieldContainer So that conditional failed. And allowed_protocol wasn't added. So instead, make that an 'else' statement. That change only resulted in 'allowed_tags' being added.
Ryan Kienstra committedDec 9, 2017 Configuration menu - View commit details
-
Copy full SHA for ae92a58 - Browse repository at this point
Copy the full SHA ae92a58View commit details
Commits on Dec 10, 2017
-
Merge branch 'develop' of https://github.com/Automattic/amp-wp into n…
…ew-clarity-develop
Configuration menu - View commit details
-
Copy full SHA for 241e866 - Browse repository at this point
Copy the full SHA 241e866View commit details -
Configuration menu - View commit details
-
Copy full SHA for 38992ed - Browse repository at this point
Copy the full SHA 38992edView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5fcbc2b - Browse repository at this point
Copy the full SHA 5fcbc2bView commit details -
Restrict screen-reader-text to Customizer preview styles
Also use AMP_QUERY_VAR instaed of hard-coded 'amp' in amp_admin_get_preview_permalink()
Configuration menu - View commit details
-
Copy full SHA for a38d024 - Browse repository at this point
Copy the full SHA a38d024View commit details
Commits on Dec 11, 2017
-
Stop <amg-audio> sanitizer from including a contained "\n" (and thus …
…breaking unit tests.)
Configuration menu - View commit details
-
Copy full SHA for 2105af0 - Browse repository at this point
Copy the full SHA 2105af0View commit details -
Configuration menu - View commit details
-
Copy full SHA for f85c366 - Browse repository at this point
Copy the full SHA f85c366View commit details -
Ensure that no errant whitespace text nodes are added to output. This…
… also required changing the output to match on two data elements in AMP_Iframe_Converter_Test->get_data()
Configuration menu - View commit details
-
Copy full SHA for 564a9d9 - Browse repository at this point
Copy the full SHA 564a9d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for f90c16d - Browse repository at this point
Copy the full SHA f90c16dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b62132a - Browse repository at this point
Copy the full SHA b62132aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5417aeb - Browse repository at this point
Copy the full SHA 5417aebView commit details -
Merge branch 'develop' of github.com:newclarity/amp-wp into develop
# Conflicts: # autoloader.php Merged in changes made by @westonruter
Configuration menu - View commit details
-
Copy full SHA for 19658c9 - Browse repository at this point
Copy the full SHA 19658c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for a66c992 - Browse repository at this point
Copy the full SHA a66c992View commit details -
Configuration menu - View commit details
-
Copy full SHA for 23bf64f - Browse repository at this point
Copy the full SHA 23bf64fView commit details -
PHP5.2: Remove '\' from on front of ReflectionClass() because PHP 5.2…
… can't handle namespace syntax.
Configuration menu - View commit details
-
Copy full SHA for bfa54bc - Browse repository at this point
Copy the full SHA bfa54bcView commit details -
Added PHPDoc explaining relative filepaths not having leading slash o…
…r .php extension.
Configuration menu - View commit details
-
Copy full SHA for 129bda7 - Browse repository at this point
Copy the full SHA 129bda7View commit details -
Added logic in AMP_DOM_Utils::get_content_from_dom() to replace <br><…
…/br> with <br/> and <hr></hr> with <hr/>.
Configuration menu - View commit details
-
Copy full SHA for b1feee0 - Browse repository at this point
Copy the full SHA b1feee0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 00bea9b - Browse repository at this point
Copy the full SHA 00bea9bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b74ee8f - Browse repository at this point
Copy the full SHA b74ee8fView commit details -
Ensure that content if retrieved via get_content_from_dom() and not v…
…ia raw $dom->saveXML().
Configuration menu - View commit details
-
Copy full SHA for 6000b50 - Browse repository at this point
Copy the full SHA 6000b50View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e0c13b - Browse repository at this point
Copy the full SHA 6e0c13bView commit details -
Configuration menu - View commit details
-
Copy full SHA for bd97046 - Browse repository at this point
Copy the full SHA bd97046View commit details -
Split get_content_from_dom() in to by adding get_content_from_dom_nod…
…e() in AMP_DOM_Utils.
Configuration menu - View commit details
-
Copy full SHA for 215a27b - Browse repository at this point
Copy the full SHA 215a27bView commit details -
Use the new AMP_DOM_Utils::get_content_from_dom_node() to make failin…
…g tests work correctly.
Configuration menu - View commit details
-
Copy full SHA for 85a46ba - Browse repository at this point
Copy the full SHA 85a46baView commit details -
Remove "repositories" from composer.json because it is not merged in …
…yet and thus is causing the build to fail.
Configuration menu - View commit details
-
Copy full SHA for de7f617 - Browse repository at this point
Copy the full SHA de7f617View commit details -
Had to remove require: php>=5.2 because it appears to be breaking the…
… build. (Methinks we would need to update the composer.json file for each Travis build to support the proper version of PHP?)
Configuration menu - View commit details
-
Copy full SHA for 5d1157f - Browse repository at this point
Copy the full SHA 5d1157fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 42c0600 - Browse repository at this point
Copy the full SHA 42c0600View commit details -
Configuration menu - View commit details
-
Copy full SHA for 47edc2f - Browse repository at this point
Copy the full SHA 47edc2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for cee3876 - Browse repository at this point
Copy the full SHA cee3876View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4597be5 - Browse repository at this point
Copy the full SHA 4597be5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e15941 - Browse repository at this point
Copy the full SHA 3e15941View commit details -
Configuration menu - View commit details
-
Copy full SHA for f5b2d2f - Browse repository at this point
Copy the full SHA f5b2d2fView commit details -
804 : Add to contributing.md, including unit test information.
Add a point that this requires WP unit tests. Also, begin with the welcome that Thierry suggested. Props @ThierryA.
Ryan Kienstra committedDec 11, 2017 Configuration menu - View commit details
-
Copy full SHA for 44554c5 - Browse repository at this point
Copy the full SHA 44554c5View commit details -
Merge branch 'feature/804-allowed-tags' of https://github.com/Automat…
…tic/amp-wp into feature/804-allowed-tags
Ryan Kienstra committedDec 11, 2017 Configuration menu - View commit details
-
Copy full SHA for ed3c93d - Browse repository at this point
Copy the full SHA ed3c93dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b416f9 - Browse repository at this point
Copy the full SHA 8b416f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 575ac66 - Browse repository at this point
Copy the full SHA 575ac66View commit details -
Merge pull request #828 from newclarity/develop
Added autoloader to reduce complexity; fix phpcs issues
Configuration menu - View commit details
-
Copy full SHA for b94b10b - Browse repository at this point
Copy the full SHA b94b10bView commit details -
Merge branch 'develop' of https://github.com/Automattic/amp-wp into f…
…eature/796-amp-customizer
Configuration menu - View commit details
-
Copy full SHA for babf16c - Browse repository at this point
Copy the full SHA babf16cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 083c9b3 - Browse repository at this point
Copy the full SHA 083c9b3View commit details -
804 : Merge in develop, resolve conflicts.
In phpcs.xml, retain edits from both branches. There were several conflicts in: class-amp-tag-and-attribute-sanitizer.php These were mainly conflicts with 03c12. Some were only DocBlocks, but some were logic. I mainly resovled them in favor of this branch: feature/804-allowed-tags.
Ryan Kienstra committedDec 11, 2017 Configuration menu - View commit details
-
Copy full SHA for c3b28c0 - Browse repository at this point
Copy the full SHA c3b28c0View commit details
Commits on Dec 12, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 64f14be - Browse repository at this point
Copy the full SHA 64f14beView commit details -
804 : Correct PHPUnit test for <script> validation.
When this has a type of 'application/json,' There is a required ancestor. So create an ancestor of <amp-analytics>.
Ryan Kienstra committedDec 12, 2017 Configuration menu - View commit details
-
Copy full SHA for 4b3ec53 - Browse repository at this point
Copy the full SHA 4b3ec53View commit details -
804 : Add spaces to correct PHPCS errors.
In response to a failed Travis build. Also, change == to ===.
Ryan Kienstra committedDec 12, 2017 Configuration menu - View commit details
-
Copy full SHA for af7b830 - Browse repository at this point
Copy the full SHA af7b830View commit details -
Add accessibility to AMP toggle; auto-show tooltip when navigating to…
… unavailable URL
Configuration menu - View commit details
-
Copy full SHA for 219f481 - Browse repository at this point
Copy the full SHA 219f481View commit details -
Only show tooltip upon unavailable if AMP is enabled.
* Remove linebreak from tooltip for alignment with autosave restore notification; tweak copy. * Move functions from inside panel ready callback to component. * Improve styling in AMP when unloading page.
Configuration menu - View commit details
-
Copy full SHA for 7308a9c - Browse repository at this point
Copy the full SHA 7308a9cView commit details -
Merge pull request #823 from Automattic/feature/804-allowed-tags
Update allowed tags and attributes, and restore ability to run script to update from spec in future
Configuration menu - View commit details
-
Copy full SHA for 7f79a50 - Browse repository at this point
Copy the full SHA 7f79a50View commit details -
Show AMP unavailable tooltip when expanding AMP panel and not on AMP-…
…compatible URL Improve styling of link in tooltip to improve color contrast
Configuration menu - View commit details
-
Copy full SHA for 79297bf - Browse repository at this point
Copy the full SHA 79297bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for b1fa356 - Browse repository at this point
Copy the full SHA b1fa356View commit details -
Merge pull request #819 from Automattic/feature/796-amp-customizer
Integrate AMP Customizer into main Customizer with new AMP toggle text to device preview
Configuration menu - View commit details
-
Copy full SHA for d952ea8 - Browse repository at this point
Copy the full SHA d952ea8View commit details -
Configuration menu - View commit details
-
Copy full SHA for a6fda64 - Browse repository at this point
Copy the full SHA a6fda64View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ef9768 - Browse repository at this point
Copy the full SHA 6ef9768View commit details
Commits on Dec 13, 2017
-
Issue 806 : Add media and embeds to test page.
Use Weston's wp-cli script to create a test post. Add media items to the post content. And add several embeds. Several embeds are still not rendering, Even on a standard, non-AMP page.
Ryan Kienstra committedDec 13, 2017 Configuration menu - View commit details
-
Copy full SHA for 550ed65 - Browse repository at this point
Copy the full SHA 550ed65View commit details -
Merge branch 'add/806-add-script-for-testing-content' of https://gith…
…ub.com/Automattic/amp-wp into add/806-add-script-for-testing-content
Ryan Kienstra committedDec 13, 2017 Configuration menu - View commit details
-
Copy full SHA for 369696b - Browse repository at this point
Copy the full SHA 369696bView commit details -
Issue 806 : Align equals signs vertically.
Before, the equals sign alignment caused a PHPCS warning. Fix this, to enable the Travis build to succeed.
Ryan Kienstra committedDec 13, 2017 Configuration menu - View commit details
-
Copy full SHA for 7c77752 - Browse repository at this point
Copy the full SHA 7c77752View commit details -
Issue 804 : Test WordPress post embeds.
create-embed-test-post.php needs to test all post content. As Weston mentioned, embedded posts are part of this.
Ryan Kienstra committedDec 13, 2017 Configuration menu - View commit details
-
Copy full SHA for 128836c - Browse repository at this point
Copy the full SHA 128836cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d72dca3 - Browse repository at this point
Copy the full SHA d72dca3View commit details -
Configuration menu - View commit details
-
Copy full SHA for b8ba836 - Browse repository at this point
Copy the full SHA b8ba836View commit details
Commits on Dec 14, 2017
-
Fix rendering of SoundCloud embeds and correct parameters for soundcl…
…oud shortcode * Hook into oEmbed filters for rewriting SoundCloud embeds as AMP components. * Ensure Jetpack is active while unit tests are run. * Explicitly install and activate Jetpack during unit tests. * Fix error message in create-embed-test-post.php * Fix phpcs for Soundcloud code.
1Configuration menu - View commit details
-
Copy full SHA for 0b729b1 - Browse repository at this point
Copy the full SHA 0b729b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 938be72 - Browse repository at this point
Copy the full SHA 938be72View commit details -
Fix handling of polldaddy oEmbeds in AMP
* Use noscript response from oEmbed as default content. * Include WPCOM_AMP_Polldaddy_Embed by default even when not on WordPress.com; deprecate wpcom/shortcodes.php. * Fix DailyMotion and FunnyOrDie test URLs. * Clean phpcs for class-amp-polldaddy-embed.php
Configuration menu - View commit details
-
Copy full SHA for 45c538c - Browse repository at this point
Copy the full SHA 45c538cView commit details -
Force is_amp_endpoint to true when rendering.
If amp_render_post is called directly outside of the standard endpoint, is_amp_endpoint will return false, which is not ideal for any code that expects to run in an AMP context (e.g. inside shortcodes). Let's force the value to be true while we render AMP content.
Configuration menu - View commit details
-
Copy full SHA for eb1d393 - Browse repository at this point
Copy the full SHA eb1d393View commit details -
Override AMP query var during rendering instead of introducing is_amp…
…_endpoint filter Remove deprecated amp_load_classes()
Configuration menu - View commit details
-
Copy full SHA for fc86d74 - Browse repository at this point
Copy the full SHA fc86d74View commit details -
Merge pull request #742 from Automattic/fix/is-amp-endpoint_for_amp-r…
…ender-post Force is_amp_endpoint to true when rendering.
Configuration menu - View commit details
-
Copy full SHA for ff2e911 - Browse repository at this point
Copy the full SHA ff2e911View commit details -
Issue 806 : Add instructions for using the wp-cli test page script.
Add steps to contributing.md to use create-embed-test-post.php. Include a step that this should be inside an environment like VVV.
Ryan Kienstra committedDec 14, 2017 Configuration menu - View commit details
-
Copy full SHA for 52b306b - Browse repository at this point
Copy the full SHA 52b306bView commit details -
Merge branch 'add/806-add-script-for-testing-content' of https://gith…
…ub.com/Automattic/amp-wp into add/806-add-script-for-testing-content
Ryan Kienstra committedDec 14, 2017 Configuration menu - View commit details
-
Copy full SHA for 13132ed - Browse repository at this point
Copy the full SHA 13132edView commit details -
Issue 804 : Add Amazon, Animoto, and Speakerdeck URLs
Add these URLs to test oEmbed. Use the Amazon testing URLs in: https://core.trac.wordpress.org/ticket/38181 Props @jsepia for these URLs.
Ryan Kienstra committedDec 14, 2017 Configuration menu - View commit details
-
Copy full SHA for eaf5157 - Browse repository at this point
Copy the full SHA eaf5157View commit details -
Issue 804 : Update the Scribd URL.
Use the URL from @wonderboymusic in: https://core.trac.wordpress.org/ticket/28379.
Ryan Kienstra committedDec 14, 2017 Configuration menu - View commit details
-
Copy full SHA for 8e34745 - Browse repository at this point
Copy the full SHA 8e34745View commit details -
Configuration menu - View commit details
-
Copy full SHA for b22e12a - Browse repository at this point
Copy the full SHA b22e12aView commit details -
Remove DoubleArrowNotAligned PHPCS suppression
* Add missing since tag * Update filter_embed_oembed_html calls since $url is required * Add DEFAULT_BASE_BRANCH=develop * Use create_and_get in test
Configuration menu - View commit details
-
Copy full SHA for f1ee3de - Browse repository at this point
Copy the full SHA f1ee3deView commit details -
Fix order of sanitizers to ensure whitelist applies at end, after ifr…
…ame sanitizer has run Issue introduced in 575ac66
Configuration menu - View commit details
-
Copy full SHA for a91d7ad - Browse repository at this point
Copy the full SHA a91d7adView commit details -
Issue 806 : Update the Photobucket and Scribd URLs.
Thanks to ohthenoes for the Photobucket link in: https://core.trac.wordpress.org/ticket/13754 And thanks to @wonderboymusic for the Scribd URL from: https://core.trac.wordpress.org/ticket/28379.
Ryan Kienstra committedDec 14, 2017 Configuration menu - View commit details
-
Copy full SHA for 499e580 - Browse repository at this point
Copy the full SHA 499e580View commit details -
Issue 806 : Merge in feature branch, resolve conflicts.
The only conflict was from array alignment. It was a whitespace-only edit.
Ryan Kienstra committedDec 14, 2017 Configuration menu - View commit details
-
Copy full SHA for 6309f41 - Browse repository at this point
Copy the full SHA 6309f41View commit details -
Issue 806 : Remove Vine embed, add Screencast embed.
Add a Screencast embed, thanks to designsimply's URL in: https://core.trac.wordpress.org/ticket/24660 Because Vine isn't supported anymore, remove its test URL. @see wordpress-develop/src/wp-includes/class-oembed.php
Ryan Kienstra committedDec 14, 2017 Configuration menu - View commit details
-
Copy full SHA for d2dd032 - Browse repository at this point
Copy the full SHA d2dd032View commit details -
Issue 806 : Add tests for Someecards.
Both the full URL, and the short URL ending with the TLD .ly. They both render well in AMP.
Ryan Kienstra committedDec 14, 2017 Configuration menu - View commit details
-
Copy full SHA for 8732936 - Browse repository at this point
Copy the full SHA 8732936View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5bce94f - Browse repository at this point
Copy the full SHA 5bce94fView commit details -
Issue 806 : Correct embeds, including Imgur, Polldaddy, Screencast.
Change the URLs for most of these. And remove the soundcloud shortcode. This isn't supported natively.
Ryan Kienstra committedDec 14, 2017 Configuration menu - View commit details
-
Copy full SHA for e885b7a - Browse repository at this point
Copy the full SHA e885b7aView commit details -
Merge branch 'add/806-add-script-for-testing-content' of https://gith…
…ub.com/Automattic/amp-wp into add/806-add-script-for-testing-content
Ryan Kienstra committedDec 14, 2017 Configuration menu - View commit details
-
Copy full SHA for a485be1 - Browse repository at this point
Copy the full SHA a485be1View commit details -
Issue 806 : Update Photobucket, Tumblr, remove Imgur.
Use mrdenn1s's image from his Trac ticket: https://core.trac.wordpress.org/ticket/28345 It looks like Imgur oEmbeds no longer work in WordPress. @see https://core.trac.wordpress.org/ticket/42247
Ryan Kienstra committedDec 14, 2017 Configuration menu - View commit details
-
Copy full SHA for ed6088d - Browse repository at this point
Copy the full SHA ed6088dView commit details -
Merge pull request #829 from Automattic/add/806-add-script-for-testin…
…g-content Add create-embed-test-post script and fix support for various embeds
Configuration menu - View commit details
-
Copy full SHA for 78c60fa - Browse repository at this point
Copy the full SHA 78c60faView commit details
Commits on Dec 19, 2017
-
Update readme for wiki; add Grunt for building and deploying
* Update phpunit coverage whitelist to include all files rather than limit to one * Fix coverage warnings * Remove tests directory from PHPCS exclusion. * Add global doc and fix phpcs in WPCOM_AMP_Polldaddy_Embed * Move contents of readme to wiki; sync readme.md with readme.txt * Remove readme-assets which have been moved to the wiki repo * Remove readme sections now in wiki; add Grunt for building and deploying * Add verify_matching_versions command from better-code-editing feature plugin * Add verify_matching_versions and phpunit as dependencies of deploy command. * Fix paths for jshint. * Add version to composer.json. * Update contributors * Add create-release-zip task as part of grunt build * Updated all version instances to 0.6 * Completed 0.6 changelog * Build 0.6-beta release
Configuration menu - View commit details
-
Copy full SHA for d5362a7 - Browse repository at this point
Copy the full SHA d5362a7View commit details
Commits on Dec 20, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 57926fb - Browse repository at this point
Copy the full SHA 57926fbView commit details
Commits on Jan 9, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 309af3d - Browse repository at this point
Copy the full SHA 309af3dView commit details
Commits on Jan 10, 2018
-
Remove pound symbol from header id
Removed the # symbol from <header> id. It was causing 404 errors and prevented the "Back to top" link in the footer from working.
elaine committedJan 10, 2018 Configuration menu - View commit details
-
Copy full SHA for b71935c - Browse repository at this point
Copy the full SHA b71935cView commit details -
Merge pull request #853 from eshannon3/eshannon3/fix-header-id to 0.6…
… branch Remove erroneous hash from id on amp-wp-header
Configuration menu - View commit details
-
Copy full SHA for ed5594b - Browse repository at this point
Copy the full SHA ed5594bView commit details
Commits on Jan 13, 2018
-
Revert "Merge pull request #725 from Automattic/amedina/add-amp-actio…
Configuration menu - View commit details
-
Copy full SHA for 13bbfab - Browse repository at this point
Copy the full SHA 13bbfabView commit details -
Merge pull request #858 from Automattic/revert/amp-actions-abstraction
Revert #725: Abstract notion of AMP Actions
Configuration menu - View commit details
-
Copy full SHA for f9eba05 - Browse repository at this point
Copy the full SHA f9eba05View commit details
Commits on Jan 15, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 2d818d5 - Browse repository at this point
Copy the full SHA 2d818d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a05c91 - Browse repository at this point
Copy the full SHA 2a05c91View commit details
Commits on Jan 17, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 57a22ca - Browse repository at this point
Copy the full SHA 57a22caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7704076 - Browse repository at this point
Copy the full SHA 7704076View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8d2d89 - Browse repository at this point
Copy the full SHA d8d2d89View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c51443 - Browse repository at this point
Copy the full SHA 8c51443View commit details
Commits on Jan 18, 2018
-
Configuration menu - View commit details
-
Copy full SHA for c9acad7 - Browse repository at this point
Copy the full SHA c9acad7View commit details -
Ensure page for posts can be served as AMP if enabled
Remove workaround that was fixed in WordPress 4.4
Configuration menu - View commit details
-
Copy full SHA for bb8743c - Browse repository at this point
Copy the full SHA bb8743cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c224abf - Browse repository at this point
Copy the full SHA c224abfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f6a0b7 - Browse repository at this point
Copy the full SHA 5f6a0b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a7f28c - Browse repository at this point
Copy the full SHA 0a7f28cView commit details -
Use temporary redirect from non-supported AMP to canonical since supp…
…ort may be enabled later
Configuration menu - View commit details
-
Copy full SHA for b0a3205 - Browse repository at this point
Copy the full SHA b0a3205View commit details -
Use register_meta() call for amp_status to expose in REST API and han…
…dle sanitization
Configuration menu - View commit details
-
Copy full SHA for 313e789 - Browse repository at this point
Copy the full SHA 313e789View commit details -
Merge pull request #872 from Automattic/add/837
Improved page default status logic and add overwrite ability; ensure front page and page for posts can be served as AMP when enabled
Configuration menu - View commit details
-
Copy full SHA for eeeaf5a - Browse repository at this point
Copy the full SHA eeeaf5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e67c12 - Browse repository at this point
Copy the full SHA 7e67c12View commit details -
Configuration menu - View commit details
-
Copy full SHA for 82c274b - Browse repository at this point
Copy the full SHA 82c274bView commit details
Commits on Jan 19, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 91ef386 - Browse repository at this point
Copy the full SHA 91ef386View commit details
Commits on Jan 22, 2018
-
Merge pull request #884 from Automattic/fix/script-additional-allowed…
…-tag Remove erroneous additional allowance of script[type=text/javascript]
Thierry Muller authoredJan 22, 2018 Configuration menu - View commit details
-
Copy full SHA for a5629f9 - Browse repository at this point
Copy the full SHA a5629f9View commit details
Commits on Jan 23, 2018
-
Address an issue where <script> tags weren't stripped.
As Weston mentioned, adding this to the post content: Hello <script>document.write('world');</script> Produced: This looks to be related to how process_node() gets the $attr_spec_list. In some cases, all will have an equal 'score,' As indicated in $spec_ids_sorted. And sometimes, all of them will be missing a mandatory attribute. In that case, $attr_spec_list will be empty. If it is, use the first spec list in: $rule_spec_list_to_validate. This will need regression testing.
Ryan Kienstra committedJan 23, 2018 Configuration menu - View commit details
-
Copy full SHA for e2f7d2e - Browse repository at this point
Copy the full SHA e2f7d2eView commit details -
Address a Travis issue by storing the result of empty() in a variable.
There was an error on the Travis build: Can't use function return value in write context. So store the result of reset() in $first_spec_list.
Ryan Kienstra committedJan 23, 2018 Configuration menu - View commit details
-
Copy full SHA for c5f5168 - Browse repository at this point
Copy the full SHA c5f5168View commit details -
Test that <script> is removed, as it is missing an attribute.
This has a mandatory attribute. And per the previous commits, It should fail validation.
Ryan Kienstra committedJan 23, 2018 Configuration menu - View commit details
-
Copy full SHA for 335d9ce - Browse repository at this point
Copy the full SHA 335d9ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for f6ef76e - Browse repository at this point
Copy the full SHA f6ef76eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 86bdf13 - Browse repository at this point
Copy the full SHA 86bdf13View commit details
Commits on Jan 24, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 17f63ac - Browse repository at this point
Copy the full SHA 17f63acView commit details -
Configuration menu - View commit details
-
Copy full SHA for d25e48f - Browse repository at this point
Copy the full SHA d25e48fView commit details -
Merge pull request #892 from Automattic/fix/script-tags-output-cdata
Address an issue where <script> tags aren't stripped.
Configuration menu - View commit details
-
Copy full SHA for 0e494a7 - Browse repository at this point
Copy the full SHA 0e494a7View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for bd6d401 - Browse repository at this point
Copy the full SHA bd6d401View commit details -
Configuration menu - View commit details
-
Copy full SHA for cceaffb - Browse repository at this point
Copy the full SHA cceaffbView commit details