Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add post embed support #914

Closed
wants to merge 4 commits into from
Closed

Conversation

westonruter
Copy link
Member

@westonruter westonruter commented Jan 29, 2018

This is split out from #889 for #841. We need a few things to fully support post embeds, including:

  • Move the contents of the blockquote.wp-embedded-content into the amp-iframe as the placeholder. Note that this must not include the blockquote itself, because wpautop will break it.
  • Allow clicking inside the post iframe to cause _top navigation.
  • Allow iframe self-resize in AMP: https://www.ampproject.org/docs/reference/components/amp-iframe#iframe-resizing
  • Consider inlining the embeds and not using an iframe at all for embeds from elsewhere on the site.

See previously for some key considerations: #288

A core patch may be required here as well.

Closes #809.

@swissspidy swissspidy mentioned this pull request Jun 6, 2019
@swissspidy
Copy link
Collaborator

@westonruter Shall we close this in favor of #3465?

@westonruter
Copy link
Member Author

Yes. Thanks!

@schlessera schlessera deleted the add/post-embed-support branch March 7, 2020 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve handling of WordPress post embeds
2 participants