Issue #864: Fix issue in 'Video' widget width in <amp-iframe>. #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Video widgets that use URLs without an AMP embed handler use: <amp-iframe> But these can be too wide for the sidebar. So apply the same fix as with <amp-video> Set a style="max-width:100%". This prevents widgets from overflowing the container. AMP_Style_Sanitizer will move it to the amp-custom style.
westonruter
approved these changes
Feb 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request For Review
Hi @westonruter,
Could you please review this pull request, which addresses the issue we discussed on PR #921 for Issue #864?
This adds
"max-width:100%"to all<amp-iframe>elements, to correct an overflow issue with 'Video' widgets that don't have embed handlers, like:https://videopress.com/v/DK5mLrbr
Also, happy belated Groundhog Day 😄