-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #841: Native AMP audio and video playlists. #954
Commits on Feb 11, 2018
-
Issue #841: Native AMP video playlists.
Create a custom shortcode handler for video playlists. Use <amp-video> and <amp-state>, on Weston't suggestion. This still doesn't support audio playlists.
Ryan Kienstra committedFeb 11, 2018 Configuration menu - View commit details
-
Copy full SHA for 00a3f08 - Browse repository at this point
Copy the full SHA 00a3f08View commit details -
Issue #841: Remove dependence on test files.
Before, test_shortcode() used test files from Core. But these did not exist in 4.7, and caused a failure. So create new mock files to test.
Ryan Kienstra committedFeb 11, 2018 Configuration menu - View commit details
-
Copy full SHA for 8140a40 - Browse repository at this point
Copy the full SHA 8140a40View commit details
Commits on Feb 13, 2018
-
Issue #841: Add audio playlist shortcode support.
Use an <amp-carousel>, As <amp-bind> doesn't work with <amp-audio>. Abstract common logic into helper methods. This mainly allows using styling from wp-mediaelement.css. But there are 4 rules needed to correct the styling.
Ryan Kienstra committedFeb 13, 2018 Configuration menu - View commit details
-
Copy full SHA for cddce46 - Browse repository at this point
Copy the full SHA cddce46View commit details -
Issue #841: Align @param descriptions in PHP DocBlock.
Ryan Kienstra committedFeb 13, 2018 Configuration menu - View commit details
-
Copy full SHA for f19c281 - Browse repository at this point
Copy the full SHA f19c281View commit details
Commits on Feb 14, 2018
-
Issue #841: Enqueue Core playlist styling, and custom styling.
The video and audio playlist need 'wp-mediaelement.' And the audio playlist needs a simple custom stylesheet. Use the action 'wp_enqueue_scripts,' instead of 'wp_playlist_script.' That enqueues too late. Also, update the tests.
Ryan Kienstra committedFeb 14, 2018 Configuration menu - View commit details
-
Copy full SHA for ca78258 - Browse repository at this point
Copy the full SHA ca78258View commit details
Commits on Feb 15, 2018
-
Issue #841: Use wp_json_encode in 'on' attribute.
At Weston's suggestion. This is easier to understand.
Ryan Kienstra committedFeb 15, 2018 Configuration menu - View commit details
-
Copy full SHA for 78f7368 - Browse repository at this point
Copy the full SHA 78f7368View commit details -
Issue #841: Move ternaary conditionals inside escaping functions.
Before, the output was only escaped if the value was set. Also, remove the isset() check for $title. As Weston mentioned, this is always a string.
Ryan Kienstra committedFeb 15, 2018 Configuration menu - View commit details
-
Copy full SHA for ccc066d - Browse repository at this point
Copy the full SHA ccc066dView commit details -
Issue #841: Empty string return in audio_playlist().
Inside a conditional, return an empty string. As Weston mentioned, the PHP DocBlock indicates a string return value. Also, add an assertion for this. And correct the documentation of 'content_width.'
Ryan Kienstra committedFeb 15, 2018 Configuration menu - View commit details
-
Copy full SHA for aba8cf1 - Browse repository at this point
Copy the full SHA aba8cf1View commit details -
Issue #841: Improve the PLAYLIST_REGEX.
Props @westonruter for the new regex. Also, remove periods from '@return void.'
Ryan Kienstra committedFeb 15, 2018 Configuration menu - View commit details
-
Copy full SHA for f13d2ad - Browse repository at this point
Copy the full SHA f13d2adView commit details -
Issue #841: Make remove_embed() add previous shortcode.
On Weston's suggestion. This function should return the shortcode to the state before this embed handler changed it. So it stores the previous callback in $removed_shortcode. And it adds that callback in remove_embed().
Ryan Kienstra committedFeb 15, 2018 Configuration menu - View commit details
-
Copy full SHA for d3cc386 - Browse repository at this point
Copy the full SHA d3cc386View commit details -
Issue #841: Return an array() inside the conditional.
As Weston mentioned, the DocBlock indicates an array(). So return an empty array instead of void.
Ryan Kienstra committedFeb 15, 2018 Configuration menu - View commit details
-
Copy full SHA for 1b07e90 - Browse repository at this point
Copy the full SHA 1b07e90View commit details -
Issue #841: Remove isset() check for $track['src'].
This should always be present. @see wp_playlist_shortcode().
Ryan Kienstra committedFeb 15, 2018 Configuration menu - View commit details
-
Copy full SHA for 168b9ba - Browse repository at this point
Copy the full SHA 168b9baView commit details -
Issue #841: Set a default height and width for 'audio.'
Audio playlists have thumbnail images. If the height and width aren't defined in $data, Set fallbacks. These are based on the fallback heights in: wp_playlist_shortcode().
Ryan Kienstra committedFeb 15, 2018 Configuration menu - View commit details
-
Copy full SHA for 7cae35c - Browse repository at this point
Copy the full SHA 7cae35cView commit details -
Issue #841: Remove the carousel buttons fro 'audio' playlist.
The playlist is actually a carousel, as it's not possible to use <amp-bind>. But that doesn't match native WP UI. So remove the buttons that go other carousel items. One can click the tracks to go to another track.
Ryan Kienstra committedFeb 15, 2018 Configuration menu - View commit details
-
Copy full SHA for d01e9ea - Browse repository at this point
Copy the full SHA d01e9eaView commit details -
Issue #841: Align equals signs to prevent Travis error.
Ryan Kienstra committedFeb 15, 2018 Configuration menu - View commit details
-
Copy full SHA for e08bc8b - Browse repository at this point
Copy the full SHA e08bc8bView commit details
Commits on Feb 17, 2018
-
Enqueue playlist styles just-in-time when used
* Restore wp_print_head_scripts and wp_print_footer_scripts. * Return associative array instead of positional array in get_thumb_dimensions. * Further clean phpdoc.
Configuration menu - View commit details
-
Copy full SHA for b093c85 - Browse repository at this point
Copy the full SHA b093c85View commit details -
Prevent playlist scripts from being enqueued which will be stripped o…
…ut anyway * Remove script output by wp_comment_form_unfiltered_html_nonce(). * Remove wp-embed script enqueued by wp_oembed_add_host_js().
Configuration menu - View commit details
-
Copy full SHA for b9d9f09 - Browse repository at this point
Copy the full SHA b9d9f09View commit details -
Configuration menu - View commit details
-
Copy full SHA for 365af92 - Browse repository at this point
Copy the full SHA 365af92View commit details
Commits on Feb 18, 2018
-
Configuration menu - View commit details
-
Copy full SHA for d94888d - Browse repository at this point
Copy the full SHA d94888dView commit details -
Merge branch 'develop' of https://github.com/Automattic/amp-wp into a…
…dd/841-amp-video-playlist
Configuration menu - View commit details
-
Copy full SHA for 13370ed - Browse repository at this point
Copy the full SHA 13370edView commit details