-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup GitHub Actions workflows #6767
Cleanup GitHub Actions workflows #6767
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Don't know if latest LTS has been tested successfully though? I think some won't work on latest.
Fair enough, I don't know why I assumed for one second that this would Just Work with a simple version bump... Let me double-check this on my fork 😅 |
Invalidating the approval so I won't accidentally merge this |
2eebab6
to
1eb23b7
Compare
Let's revert the |
ACT
env variablenpm install
withnpm ci
(CI jobs should not regenerate package-lock.json)Update NodeJS version from(reverted for now, will deal with this later)14
tolts
action/cache
and replace with the built-in caching mechanism inaction/setup-node
workflow-dispatch:
trigger (manual trigger) to all remaining workflows, so we can trigger them on PRs that we want to double-check, even if the PR itself doesn't trigger those workflows automatically