Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup GitHub Actions workflows #6767

Merged

Conversation

danielrozenberg
Copy link
Member

@danielrozenberg danielrozenberg commented Feb 15, 2024

  • Remove jobs that have been manually disabled or were never configured correctly
  • Remove reference to the non-existent ACT env variable
  • Replace npm install with npm ci (CI jobs should not regenerate package-lock.json)
  • Renamed *.yml to *.yaml to keep consistent :)
  • Update NodeJS version from 14 to lts (reverted for now, will deal with this later)
  • Remove the custom call to action/cache and replace with the built-in caching mechanism in action/setup-node
  • Add workflow-dispatch: trigger (manual trigger) to all remaining workflows, so we can trigger them on PRs that we want to double-check, even if the PR itself doesn't trigger those workflows automatically

Copy link
Collaborator

@powerivq powerivq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Don't know if latest LTS has been tested successfully though? I think some won't work on latest.

@danielrozenberg
Copy link
Member Author

Thanks! Don't know if latest LTS has been tested successfully though? I think some won't work on latest.

Fair enough, I don't know why I assumed for one second that this would Just Work with a simple version bump... Let me double-check this on my fork 😅

@danielrozenberg danielrozenberg mentioned this pull request Feb 16, 2024
1 task
@danielrozenberg
Copy link
Member Author

Invalidating the approval so I won't accidentally merge this

@danielrozenberg danielrozenberg marked this pull request as draft February 16, 2024 19:58
@danielrozenberg
Copy link
Member Author

Let's revert the lts change in this PR, I'll deal with that specific change in a separate PR. Re-approval required :)

@danielrozenberg danielrozenberg marked this pull request as ready for review February 20, 2024 16:42
@danielrozenberg danielrozenberg merged commit 9803724 into ampproject:main Feb 21, 2024
2 checks passed
@danielrozenberg danielrozenberg deleted the remove-disabled-workflows branch February 21, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants