Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform PR build test #6788

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Perform PR build test #6788

merged 3 commits into from
Apr 4, 2024

Conversation

powerivq
Copy link
Collaborator

@powerivq powerivq commented Mar 28, 2024

Currently, there is no PR build tests. We can merge something that breaks. This PR adds the test.

@powerivq powerivq changed the title DONOTSUBMIT test Perform PR build test Apr 2, 2024
.github/workflows/lint.yaml Outdated Show resolved Hide resolved
.github/workflows/lint.yaml Outdated Show resolved Hide resolved
powerivq and others added 2 commits April 3, 2024 12:32
Co-authored-by: Daniel Rozenberg <rodaniel@amp.dev>
@powerivq
Copy link
Collaborator Author

powerivq commented Apr 4, 2024

Updated PR, but @danielrozenberg can you do a final check to make sure I understand that correctly?

Copy link
Member

@danielrozenberg danielrozenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Ship it 🚢

@powerivq powerivq merged commit efb03d9 into main Apr 4, 2024
4 checks passed
@powerivq powerivq deleted the test-build branch April 4, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants