Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary new paragraph in style_pages.md #6838

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

zhangsu
Copy link
Member

@zhangsu zhangsu commented Aug 14, 2024

#6833 took a shortcut and applied the format filter on just part of the sentence. This resulted in the word "stylesheets" being put in a new paragraph after the word "external". Apparently, the filter mechanism always creates a new paragraph as opposed to coalescing all whitespace characters into a single space.

To fix this, we will have to duplicate some parts of the sentence, unfortunately.

/to @powerivq

ampproject#6833 took a shortcut and applied the format filter on just part of the sentence. This resulted in the word "stylesheets" being put in a new paragraph after the word "external". Apparently, the filter mechanism always creates a new paragraph as opposed to coalescing all whitespace characters into a single space.

To fix this, we will have to duplicate some parts of the sentence, unfortunately.
@powerivq powerivq merged commit c6a7b00 into ampproject:main Aug 14, 2024
4 checks passed
@powerivq powerivq self-assigned this Aug 14, 2024
@zhangsu zhangsu deleted the patch-1 branch August 16, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants