self nits

ampproject · Apr 30, 2021 · d55aad1 · d55aad1
1 parent 59758fa
commit d55aad1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 11 deletions.
diff --git a/build-system/tasks/check-types.js b/build-system/tasks/check-types.js
@@ -227,10 +227,8 @@ async function typeCheck(targetName) {
  * of closure errors.
  *
  * This is a temporary measure while we restore 100% typechecking.
- *
- * @param {Array<string>} entryPoints
  */
-async function ensureMinTypeQuality(entryPoints) {
+async function ensureMinTypeQuality() {
   const srcGlobs = ['src/**/*.js', 'extensions/**/*.js'];
   const errorsToCheckFor = [
     'JSC_BAD_JSDOC_ANNOTATION',
@@ -239,7 +237,7 @@ async function ensureMinTypeQuality(entryPoints) {
   ];
 
   let msg = '';
-  await closureCompile(entryPoints, './dist', `check-types.js`, {
+  await closureCompile('src/amp.js', './dist', `check-types.js`, {
     include3pDirectories: false,
     includePolyfills: false,
     typeCheckOnly: true,
@@ -282,7 +280,7 @@ async function checkTypes() {
   log(`Checking types for targets: ${targets.map(cyan).join(', ')}`);
   displayLifecycleDebugging();
 
-  await ensureMinTypeQuality(['src/amp.js']);
+  await ensureMinTypeQuality();
   await Promise.all(targets.map(typeCheck));
   exitCtrlcHandler(handlerProcess);
 }

diff --git a/extensions/amp-bind/0.1/bind-impl.js b/extensions/amp-bind/0.1/bind-impl.js
@@ -99,14 +99,11 @@ let BoundElementDef;
 
 /**
  * The options bag for binding application.
- * - skipAmpState: If true, skips <amp-state> elements.
- * - constrain: If provided, restricts application to children of the provided elements.
- * - evaluateOnly: If provided, caches the evaluated result on each bound element and skips the actual DOM updates.
  *
  * @typedef {Record} ApplyOptionsDef
- * @property {boolean=} skipAmpState - If true, skips <amp-state> elements.
- * @property {Array<!Element>=} constrain
- * @property {boolean=} evaluateOnly
+ * @property {boolean=} skipAmpState If true, skips <amp-state> elements.
+ * @property {Array<!Element>=} constrain If provided, restricts application to children of the provided elements.
+ * @property {boolean=} evaluateOnly If provided, caches the evaluated result on each bound element and skips the actual DOM updates.
  */
 
 /**