Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move away from custom closure passes and transformation #17120

Closed
2 of 4 tasks
erwinmombay opened this issue Jul 26, 2018 · 12 comments · Fixed by #24047
Closed
2 of 4 tasks

move away from custom closure passes and transformation #17120

erwinmombay opened this issue Jul 26, 2018 · 12 comments · Fixed by #24047
Assignees
@jridgewell @erwinmombay @rsimha
Labels
P1: High Priority WG: infra
Milestone
Pending Triage

Comments

@erwinmombay
Copy link
Member

erwinmombay commented Jul 26, 2018 •
edited
Loading

  • babel DCE assert
  • babel constant transform
  • eslint no-reassign-dev-user symbols
  • pre processing pipeline
@erwinmombay
Copy link
Member Author

#17114

@erwinmombay erwinmombay self-assigned this Jul 26, 2018
@erwinmombay erwinmombay added this to the Pending Triage milestone Aug 21, 2018
@erwinmombay
Copy link
Member Author

This is a high priority issue but it hasn't been updated in awhile. @erwinmombay Do you have any updates?

3 similar comments
@ampprojectbot
Copy link
Member

This is a high priority issue but it hasn't been updated in awhile. @erwinmombay Do you have any updates?

@ampprojectbot
Copy link
Member

This is a high priority issue but it hasn't been updated in awhile. @erwinmombay Do you have any updates?

@ampprojectbot
Copy link
Member

This is a high priority issue but it hasn't been updated in awhile. @erwinmombay Do you have any updates?

@rsimha
Copy link
Contributor

rsimha commented Nov 19, 2018 •
edited
Loading

Happy to work on some pieces of this. @erwinmombay, do you have any documentation / issue comments that describe the individual tasks that need to be carried out?

@rsimha rsimha self-assigned this Nov 19, 2018
@ampprojectbot
Copy link
Member

This is a high priority issue but it hasn't been updated in awhile. @erwinmombay Do you have any updates?

2 similar comments
@ampprojectbot
Copy link
Member

This is a high priority issue but it hasn't been updated in awhile. @erwinmombay Do you have any updates?

@ampprojectbot
Copy link
Member

This is a high priority issue but it hasn't been updated in awhile. @erwinmombay Do you have any updates?

@rsimha
Copy link
Contributor

rsimha commented Apr 29, 2019

@jridgewell knows how to do these with Babel. If so, we can eliminate the need for a custom runner.jar

@rsimha
Copy link
Contributor

rsimha commented May 31, 2019

With #22056, single pass no longer uses a custom runner.jar. We still need one for multi pass.

@jridgewell or @erwinmombay can comment on what's left to do, and when this can be closed.

This was referenced Jul 17, 2019
Merged
Merged
Merged
Merged
@rsimha rsimha mentioned this issue Aug 22, 2019
Merged
@rsimha
Copy link
Contributor

rsimha commented Apr 30, 2020

This issue is still blocked by #23960, and can be closed once #24047 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jridgewell jridgewell

@erwinmombay erwinmombay

@rsimha rsimha

Labels
P1: High Priority WG: infra
Projects
None yet
Milestone
Pending Triage
Development

Successfully merging a pull request may close this issue.

🏗🚮 Remove AmpPass.java
4 participants
@jridgewell @erwinmombay @ampprojectbot @rsimha