✨ Launch Custom Elements v1 Polyfill #25141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There don't seem to be any errors. Let's launch!
|
Hey @rsimha, these files were changed:
|
kristoferbaxter
approved these changes
Oct 18, 2019
|
|
This is great. One question: are we utilizing the browser's native CustomElement support (with module-no-module)? |
|
No, we still always polyfill. We weren't confident that our use of Custom Elements matched the spec, so we decided to always polyfill. We can now begin experiments with using native CEv1. |
rsimha
approved these changes
Oct 18, 2019
|
/cc @keithwrightbos @jeffkaufman FYI, once merged it will be in RC next Tuesday. Please keep an eye on ads dashboard. |
IE11 doesn't have `"[native code]"`, instead it returns `"[object HTMLElement]"`. Well, if there's no CE, then we obviously need to polyfill anyways.
IE11 puts the `innerHTML` accessor on `HTMLElement.prototype`, not `Element.prototype`. And we've already replaced `HTMLElement` with our polyfill class. That polyfill class directly inherits from the native `HTMLElement`, so we can access it via the `__proto__` field.
rsimha
reviewed
Oct 19, 2019
jeffjose
pushed a commit
to jeffjose/amphtml
that referenced
this pull request
Oct 19, 2019
* Launch Custom Elements v1 Polyfill There don't seem to be any errors. Let's launch! * Always use customElements registry * Fix isPatched check IE11 doesn't have `"[native code]"`, instead it returns `"[object HTMLElement]"`. Well, if there's no CE, then we obviously need to polyfill anyways. * Fix IE11 innerHTML overwrite IE11 puts the `innerHTML` accessor on `HTMLElement.prototype`, not `Element.prototype`. And we've already replaced `HTMLElement` with our polyfill class. That polyfill class directly inherits from the native `HTMLElement`, so we can access it via the `__proto__` field.
joshuarrrr
pushed a commit
to Parsely/amphtml
that referenced
this pull request
Oct 22, 2019
* Launch Custom Elements v1 Polyfill There don't seem to be any errors. Let's launch! * Always use customElements registry * Fix isPatched check IE11 doesn't have `"[native code]"`, instead it returns `"[object HTMLElement]"`. Well, if there's no CE, then we obviously need to polyfill anyways. * Fix IE11 innerHTML overwrite IE11 puts the `innerHTML` accessor on `HTMLElement.prototype`, not `Element.prototype`. And we've already replaced `HTMLElement` with our polyfill class. That polyfill class directly inherits from the native `HTMLElement`, so we can access it via the `__proto__` field.
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
* Launch Custom Elements v1 Polyfill There don't seem to be any errors. Let's launch! * Always use customElements registry * Fix isPatched check IE11 doesn't have `"[native code]"`, instead it returns `"[object HTMLElement]"`. Well, if there's no CE, then we obviously need to polyfill anyways. * Fix IE11 innerHTML overwrite IE11 puts the `innerHTML` accessor on `HTMLElement.prototype`, not `Element.prototype`. And we've already replaced `HTMLElement` with our polyfill class. That polyfill class directly inherits from the native `HTMLElement`, so we can access it via the `__proto__` field.
This was referenced Apr 22, 2020
This was referenced May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There don't seem to be any errors. Let's launch!
Note, we're still always polyfilling. But this gets us one step closer to using native Custom Elements v1 when supported (either via ES6 classes, or a minimal wrapper polyfill instead of a full polyfill).