Resources: Don't become ready for layout if already scheduled #29389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
changed the title
dreamofabear
approved these changes
Jul 21, 2020
jridgewell
changed the title
|
Is this fix live? We've seeing this issue again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#29078 is happening way too frequently. Tracking it down, it's caused by elements that use
isRelayoutNeeded. This means every time the element is measured (which happens every resource pass for these elements), they're setting their resource state toREADY_FOR_LAYOUT. Normally, that's not an issue. But, we also happens to trigger this measurement directly before callingstartLayout, which means every single element that usesisRelayoutNeededwould always fire this bug every single time.This fixes the bug, by only setting to
READY_FOR_LAYOUTif the element is inLAYOUT_COMPLETEstate (orFAILED). And that prevents the bug because we'd no longer transition away fromLAYOUT_SCHEDULEDjust before callingstartLayout.This re-enables the logging disabled in #29381.
Fixes #29078