✨ Bento amp-video-iframe #31055
Merged
✨ Bento amp-video-iframe #31055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanorozco
commented
Nov 10, 2020
| @@ -21,6 +21,29 @@ const TAG = 'amp-video'; | |||
|
|
|||
| class AmpVideo extends VideoBaseElement {} | |||
|
|
|||
| /** @override */ | |||
| AmpVideo['props'] = { | |||
There was a problem hiding this comment.
Moved since props vary by component, so I think they should be specified individually.
Comment on lines
73
to
75
| 'component': VideoIframe, | ||
| 'onMessage': onMessage, | ||
| 'makeMethodMessage': makeMethodMessage, |
There was a problem hiding this comment.
This doesn't need a specific component, but only specific props.
This can be the case for 3p players like amp-youtube too, where we can specify its behavior only by changing props.
In a future world where CE get compiled away, for other components this can be expressed in one of two ways.
From:
<amp-youtube ...></amp-youtube>Into:
A.
<Youtube ... />or B.
<VideoIframe makeMethodMessage={YOUTUBE_MAKE_METHOD_MESSAGE} ... />This is irrelevant for this PR, but it might be interesting to note.
alanorozco
commented
Nov 10, 2020
dvoytenko
previously requested changes
Nov 11, 2020
…frame # Conflicts: # build-system/compile/bundles.config.js # extensions/amp-video-iframe/0.1/amp-video-iframe.js # extensions/amp-video/1.0/base-element.js # extensions/amp-video/1.0/video-wrapper.js
caroqliu
reviewed
Apr 26, 2021
samouri
approved these changes
Apr 29, 2021
alanorozco
force-pushed
the
amp-video-iframe
branch
from
eb6cd4d to
b51023c
Compare
rochapablo
pushed a commit
to rochapablo/amphtml
that referenced
this pull request
Aug 30, 2021
<amp-video-iframe> that uses a Preact VideoIframe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.