Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove getPageLayoutBox, getLayoutBox, and getIntersectionChangeEntry APIs from docking #31749

Merged
merged 2 commits into from
Dec 28, 2020

Conversation

dvoytenko
Copy link
Contributor

Partial for #31540.

A more holistic rewrite could eliminate significant amount of measures. However, in my analysis:

  1. Most of the measurements (and most performance sensitive ones) happen as the result of PositionObserver callback. However, that callback, conveniently, provides the ClientRect structure, which I used when possible to eliminate most of the measurements.
  2. The code as it stands is fairly efficient. E.g. it starts monitoring of positions only when the element is in a right corridor.

Copy link
Member

@samouri samouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming you've tested the functionality, code LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants