Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Report cls-fcp and cls-ofv to compare with cls #33207

Merged
merged 4 commits into from
Mar 11, 2021

Conversation

rcebulko
Copy link
Contributor

@rcebulko rcebulko commented Mar 11, 2021

Data suggests some CLS violations are occurring either before FCP, before iframe visibility, or both. This PR adds reporting for two new metrics:

  • cls-fcp: CLS at the time of the first contentful paint
  • cls-ofv: CLS at the time the AMP doc becomes visible

Copy link
Contributor

@kristoferbaxter kristoferbaxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Good to get another reviewer @ampproject/wg-performance?

src/enums.js Outdated Show resolved Hide resolved
Copy link
Contributor

@kristoferbaxter kristoferbaxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval for bundle-size.

@kristoferbaxter kristoferbaxter merged commit bff78f6 into ampproject:master Mar 11, 2021
@kristoferbaxter kristoferbaxter changed the title 🚀 Report cls-fcp and cls-vis to compare with cls 🚀 Report cls-fcp and cls-ofv to compare with cls Mar 11, 2021
ampprojectbot pushed a commit that referenced this pull request Mar 11, 2021
* Report cls-fcp and cls-vis

* Add tests

* Add issue #

* rename cls-vis to cls-ofv

Co-authored-by: Erwin Mombay <erwinm@google.com>
(cherry picked from commit bff78f6)
@rcebulko
Copy link
Contributor Author

@erwinmombay Thanks for pushing this across the finish line!

ampprojectbot pushed a commit that referenced this pull request Mar 12, 2021
* Report cls-fcp and cls-vis

* Add tests

* Add issue #

* rename cls-vis to cls-ofv

Co-authored-by: Erwin Mombay <erwinm@google.com>
(cherry picked from commit bff78f6)
westonruter added a commit to westonruter/amphtml that referenced this pull request Mar 15, 2021
* 'master' of github.com:ampproject/amphtml: (536 commits)
  ✨ Send extension versions from AMPHTML ads to FIE  (ampproject#33190)
  Update amp-autocomplete test output file (ampproject#33216)
  ✨ Changing Inline Page Attachment Button UI  (ampproject#33142)
  ✨Launch no-signing (ampproject#33229)
  ♻️ Add logic for story ad page manager. (ampproject#33201)
  Migrate Bento components to V1 (ampproject#32974)
  📦 Update dependency mocha to v8.3.2 (ampproject#33234)
  📦 Update build system devDependencies (ampproject#33178)
  🧪 [amp-consent] Turn on TCF PostMessage Proxy API Experiment (ampproject#33196)
  Fix amp-video amp_video_quality parameter name. (ampproject#33227)
  🏗 Guard access to `BASH_ENV` during CircleCI push builds (ampproject#33231)
  🏗 Clean up CircleCI merge SHA logic (ampproject#33215)
  📦 Update dependency karma to v6.1.2 (ampproject#33151)
  🏗 Ensure up-to-date and clean `package-lock.json` before running any CI job (ampproject#33223)
  Ensure that pre-stubbing always happens before the first element is upgraded (ampproject#33212)
  🏗 Restore `package-lock.json` to `lockfileVersion = 1` (ampproject#33222)
  Fixed text align of buttons (ampproject#33217)
  [amp-story] ♿ Add label for next story and add i18n for pagination buttons (ampproject#33205)
  [amp-story-player] 📖  Rename skip-next control to skip-to-next (ampproject#33164)
  🚀 Report cls-fcp and cls-vis to compare with cls (ampproject#33207)
  ...
muuki88 pushed a commit to highfivve/amphtml that referenced this pull request Mar 15, 2021
* Report cls-fcp and cls-vis

* Add tests

* Add issue #

* rename cls-vis to cls-ofv

Co-authored-by: Erwin Mombay <erwinm@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants