Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy sidebar to set container for Bento mounting #33503

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

dvoytenko
Copy link
Contributor

Follow up on #33281

Partial for #31915.
Partial for #31540.

@dvoytenko dvoytenko requested review from jridgewell and samouri March 25, 2021 22:05
@dvoytenko dvoytenko merged commit 30dba7c into ampproject:master Mar 25, 2021
@dvoytenko dvoytenko deleted the bento/sidebars-container branch March 25, 2021 22:44
@samouri
Copy link
Member

samouri commented Mar 26, 2021

Do you have a list of all the legacy components that need this update?

@dvoytenko
Copy link
Contributor Author

Do you have a list of all the legacy components that need this update?

I believe these are all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants