Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏗 Format forbidden term report message #33504

Merged
merged 2 commits into from
Mar 25, 2021
Merged

🏗 Format forbidden term report message #33504

merged 2 commits into from
Mar 25, 2021

Conversation

alanorozco
Copy link
Member

  • Remove newline
  • Add period to message only if needed

@alanorozco alanorozco requested a review from rsimha March 25, 2021 22:14
@amp-owners-bot
Copy link

Hey @erwinmombay, @jridgewell! These files were changed:

build-system/eslint-rules/no-forbidden-terms.js

@alanorozco alanorozco mentioned this pull request Mar 25, 2021
Merged
rsimha
rsimha approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with an optional suggestion to make the output easier to read.

build-system/eslint-rules/no-forbidden-terms.js Outdated Show resolved Hide resolved
build-system/eslint-rules/no-forbidden-terms.js Show resolved Hide resolved
@alanorozco alanorozco merged commit 73a5ba1 into ampproject:master Mar 25, 2021
@alanorozco alanorozco deleted the terms-message branch March 25, 2021 23:11
rochapablo pushed a commit to rochapablo/amphtml that referenced this pull request Aug 30, 2021
@alanorozco @rochapablo
🏗 Format forbidden term report message (ampproject#33504)
335b089 
- Remove newline
- Add period to message only if needed
- Add color to term
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsimha rsimha rsimha approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alanorozco @rsimha @ampprojectbot